From: Nick Bowler <nbowler@elliptictech.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Subject: [PATCH 0/2] AH fixes for asynchronous hash algorithms.
Date: Tue, 8 Nov 2011 17:12:43 -0500 [thread overview]
Message-ID: <1320790365-29152-1-git-send-email-nbowler@elliptictech.com> (raw)
Here are two fixes for AH when using an asynchronous hmac driver. Both
are -stable candidates as these problems appear to have been present
since AH was converted to use ahash way back in 2.6.33.
These code paths are not exercised when using the default software hash
implementations which do not use the ahash callbacks, but the issues can be
reproduced by using cryptd to create an asynchronous hash algorithm for
testing.
This driver could probably do with some cleanups to reduce the code
duplication (and thus test coverage) between the asynchronous callbacks
and synchronous code paths, which should help avoid these kind of
problems in the future. These code paths apparently do not see a
lot of testing. But that's for a later patch series.
Nick Bowler (2):
ah: Correctly pass error codes in ahash output callback.
ah: Read nexthdr value before overwriting it in ahash input callback.
net/ipv4/ah4.c | 6 ++----
net/ipv6/ah6.c | 6 ++----
2 files changed, 4 insertions(+), 8 deletions(-)
--
1.7.3.4
next reply other threads:[~2011-11-08 22:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 22:12 Nick Bowler [this message]
2011-11-08 22:12 ` [PATCH 1/2] ah: Correctly pass error codes in ahash output callback Nick Bowler
2011-11-08 22:12 ` [PATCH 2/2] ah: Read nexthdr value before overwriting it in ahash input callback Nick Bowler
2011-11-09 20:56 ` [PATCH 0/2] AH fixes for asynchronous hash algorithms David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320790365-29152-1-git-send-email-nbowler@elliptictech.com \
--to=nbowler@elliptictech.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox