From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: steffen.klassert@secunet.com, netdev@vger.kernel.org, timo.teras@iki.fi
Subject: Re: dst->obsolete has become pointless
Date: Wed, 09 Nov 2011 15:56:09 -0800 [thread overview]
Message-ID: <1320882969.6923.29.camel@Joe-Laptop> (raw)
In-Reply-To: <20111109.142044.1307358041881082836.davem@davemloft.net>
On Wed, 2011-11-09 at 14:20 -0500, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Wed, 09 Nov 2011 04:49:08 -0800
>
> > On Tue, 2011-11-08 at 13:59 -0500, David Miller wrote:
> >> net: Kill pointless and misleading checks on dst->obsolete.
> > []
> >> Therefore rename it to dst->freed, and make it take on only the values
> >> "0" and "1".
> >> diff --git a/include/net/dst.h b/include/net/dst.h
> > []
> >> @@ -55,7 +55,7 @@ struct dst_entry {
> >> #define DST_NOCOUNT 0x0020
> >>
> >> short error;
> >> - short obsolete;
> >> + unsigned short freed;
> >
> > perhaps
> > bool freed;
> > bool __pad3;
> > just to mark the available space a bit more obviously.
>
> Hmmm, what is a bool's defined type anyways? It is a char on every
> architecture and ABI?
As far as I know, other than being large enough to
store a 1 and 0, it's implementation defined.
Just like an unsigned short.
I _believe_ gcc uses unsigned char width for
_Bool in all normal cases though.
next prev parent reply other threads:[~2011-11-09 23:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-05 3:09 dst->obsolete has become pointless David Miller
2011-11-08 9:34 ` Steffen Klassert
2011-11-08 17:20 ` David Miller
2011-11-08 18:59 ` David Miller
2011-11-09 12:49 ` Joe Perches
2011-11-09 19:20 ` David Miller
2011-11-09 23:56 ` Joe Perches [this message]
2011-11-10 0:24 ` David Miller
2011-11-10 0:33 ` Eric Dumazet
2011-11-10 0:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320882969.6923.29.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).