From: Ben Hutchings <bhutchings@solarflare.com>
To: Dmitry Kravkov <dmitry@broadcom.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
Ariel Elior <ariele@broadcom.com>,
Eilon Greenstein <eilong@broadcom.com>
Subject: Re: [PATCH net-next 09/13] bnx2x: add pri_map module parameter
Date: Thu, 10 Nov 2011 17:39:47 +0000 [thread overview]
Message-ID: <1320946787.2851.2.camel@bwh-desktop> (raw)
In-Reply-To: <1320938054-31288-10-git-send-email-dmitry@broadcom.com>
On Thu, 2011-11-10 at 17:14 +0200, Dmitry Kravkov wrote:
> From: Ariel Elior <ariele@broadcom.com>
>
> The optional parameter pri_map is used to map the
> skb->priority to a Class Of Service (CoS) in the HW.
> This 32 bit parameter is evaluated by the driver as 8
> values of 4 bits each. Each nibble sets the desired
> HW queue number for that priority.
[...]
You should implement ndo_tc_setup instead of adding a driver-specific
parameter (that should be per-device anyway).
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-11-10 17:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 15:14 [PATCH net-next 00/13] bnx2x series Dmitry Kravkov
2011-11-10 15:14 ` [PATCH net-next 01/13] bnx2x: allow FCoE and DCB for 578xx Dmitry Kravkov
2011-11-10 15:14 ` [PATCH net-next 02/13] bnx2x: use rx_queue index for skb_record_rx_queue() Dmitry Kravkov
2011-11-10 15:14 ` [PATCH net-next 03/13] bnx2x: remove unused variable Dmitry Kravkov
2011-11-10 15:14 ` [PATCH net-next 04/13] bnx2x: separate FCoE and iSCSI license initialization Dmitry Kravkov
2011-11-10 15:14 ` [PATCH net-next 05/13] bnx2x: propagate DCBX negotiation Dmitry Kravkov
2011-11-10 15:14 ` [PATCH net-next 06/13] bnx2x: DCBX: use #define instead of magic Dmitry Kravkov
2011-11-10 15:14 ` [PATCH net-next 07/13] bnx2x: simplify definition of RX_SGE_MASK_LEN and use it Dmitry Kravkov
2011-11-10 15:14 ` [PATCH net-next 08/13] bnx2x: remove unused #define Dmitry Kravkov
2011-11-10 15:14 ` [PATCH net-next 09/13] bnx2x: add pri_map module parameter Dmitry Kravkov
2011-11-10 17:39 ` Ben Hutchings [this message]
[not found] ` <CAM8tLiMATfsH1mqmgrALX9o+5nWEahntCAc2ewm0RF_kbt=82A@mail.gmail.com>
2011-11-10 20:21 ` Dmitry Kravkov
2011-11-10 20:34 ` John Fastabend
2011-11-13 12:30 ` Dmitry Kravkov
2011-11-12 5:50 ` David Miller
2011-11-10 15:14 ` [PATCH net-next 10/13] bnx2x: add fan failure event handling Dmitry Kravkov
2011-11-10 15:14 ` [PATCH net-next 11/13] bnx2x: prevent race in statistics flow Dmitry Kravkov
2011-11-10 15:14 ` [PATCH net-next 12/13] bnx2x: Remove on-stack napi struct variable Dmitry Kravkov
2011-11-10 15:14 ` [PATCH net-next 13/13] bnx2x: update driver version to 1.70.35-0 Dmitry Kravkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320946787.2851.2.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=ariele@broadcom.com \
--cc=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).