From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Fritz, Wolfgang" Subject: Re: [PATCH] net, bridge: print log message after state changed Date: Mon, 14 Nov 2011 08:03:31 +0100 Message-ID: <1321254211.4072.29.camel@pc005091.de.keymile.net> References: <1320941934-3534-1-git-send-email-holger.brunck@keymile.com> <20111114.003702.1097206603722725705.davem@davemloft.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1362143575534058751==" Cc: netdev@vger.kernel.org, shemminger@linux-foundation.org, bridge@lists.linux-foundation.org, "Brunck, Holger" To: "David Miller" Return-path: Content-class: urn:content-classes:message In-Reply-To: <20111114.003702.1097206603722725705.davem@davemloft.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org This is a multi-part message in MIME format. --===============1362143575534058751== Content-class: urn:content-classes:message Content-Type: multipart/alternative; boundary="----_=_NextPart_001_01CCA29B.843E701A" This is a multi-part message in MIME format. ------_=_NextPart_001_01CCA29B.843E701A Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable Am Montag, den 14.11.2011, 00:37 -0500 schrieb David Miller: > From: Holger Brunck > Date: Thu, 10 Nov 2011 17:18:54 +0100 >=20 > > From: Wolfgang Fritz > >=20 > > Function br_log_state writes log message "... entering XXXX state" = so it > > should be called after the state has changed and not before. > >=20 > > Signed-off-by: Wolfgang Fritz > > Signed-off-by: Holger Brunck >=20 > "entering" can roughly mean "about to enter" >=20 Exactly. > The message is therefore appropriately timed as far as I'm concerned. >=20 It's not. Please test: create a bridge with STP disabled, add an interface to the bridge and set that interface down. You get the message "... entering forwarding state". That's wrong because it's "about to enter" disabled state some lines later. All other (4) calls to br_log_state are located after the state change, see for example br_stp_enable_port() just some lines above the patch. Regards, Wolfgang=20 > I'm not applying this patch. >=20 --=20 "I love deadlines. I like the whooshing sound they make as they fly by" (Douglas Adams) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D KEYMILE GmbH mailto:wolfgang.fritz@keymile.com Wolfgang Fritz Phone: +49 (0)511 6747-692 Wohlenbergstr. 3 Fax: +49 (0)511 6747-777 D-30179 Hannover http://www.keymile.com Managing Directors: Bj=F6rn Claa=DFen, Dipl.-Kfm. Andreas Gebauer Legal structure: GmbH, Registered office: Hanover, HRB 61069=20 Local court Hanover, VAT-Reg.-No.: DE 812282795,=20 WEEE-Reg.-No.: DE 59336750 ------_=_NextPart_001_01CCA29B.843E701A Content-Type: text/html; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable Re: [PATCH] net, bridge: print log message after state = changed

Am Montag, den 14.11.2011, 00:37 -0500 schrieb David = Miller:
> From: Holger Brunck <holger.brunck@keymile.com>
> Date: Thu, 10 Nov 2011 17:18:54 +0100
>
> > From: Wolfgang Fritz <wolfgang.fritz@keymile.com>
> >
> > Function br_log_state writes log message "... entering = XXXX state" so it
> > should be called after the state has changed and not = before.
> >
> > Signed-off-by: Wolfgang Fritz = <wolfgang.fritz@keymile.com>
> > Signed-off-by: Holger Brunck = <holger.brunck@keymile.com>
>
> "entering" can roughly mean "about to = enter"
>

Exactly.

> The message is therefore appropriately timed as far as I'm = concerned.
>

It's not.

Please test: create a bridge with STP disabled, add an interface to = the
bridge and set that interface down. You get the message "... = entering
forwarding state". That's wrong because it's "about to = enter" disabled
state some lines later.

All other (4) calls to br_log_state are located after the state = change,
see for example br_stp_enable_port() just some lines above the = patch.

Regards,
Wolfgang


> I'm not applying this patch.
>
--
"I love deadlines. I like the whooshing sound they make as they fly = by"
(Douglas Adams)
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
KEYMILE GmbH       mailto:wolfgang.fritz@keymile.= com
Wolfgang Fritz     Phone: +49 (0)511 6747-692
Wohlenbergstr. 3   Fax:   +49 (0)511 6747-777
D-30179 Hannover   http://www.keymile.com

Managing Directors: Bj=F6rn Claa=DFen, Dipl.-Kfm. Andreas Gebauer
Legal structure: GmbH, Registered office: Hanover, HRB 61069
Local court Hanover, VAT-Reg.-No.: DE 812282795,
WEEE-Reg.-No.: DE 59336750

------_=_NextPart_001_01CCA29B.843E701A-- --===============1362143575534058751== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Bridge mailing list Bridge@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/bridge --===============1362143575534058751==--