From: Ben Hutchings <bhutchings@solarflare.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: <netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v5 2/9] net: ethtool: break association of ETH_FLAG_* with NETIF_F_*
Date: Wed, 16 Nov 2011 02:06:45 +0000 [thread overview]
Message-ID: <1321409205.2744.36.camel@bwh-desktop> (raw)
In-Reply-To: <768d41024675f5dd2ca20e77e2f04cc7a8aa0519.1321404954.git.mirq-linux@rere.qmqm.pl>
On Wed, 2011-11-16 at 02:29 +0100, Michał Mirosław wrote:
> This is the only place left where dev->features are directly
> exposed to userspace.
>
> I know checkpatch.pl complains about __ethtool_{get,set}_flags(), but
> the code is easier to read this way.
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-11-16 2:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 1:29 [PATCH v5 0/9] Cleanup and extension of netdev features Michał Mirosław
2011-11-16 1:29 ` [PATCH v5 9/9] net: remove NETIF_F_NO_CSUM feature bit Michał Mirosław
2011-11-16 1:29 ` [PATCH v5 6/9] net: ethtool: use C99 array initialization for feature-names table Michał Mirosław
2011-11-16 22:40 ` Ben Hutchings
2011-11-16 1:29 ` [PATCH v5 7/9] ethtool: prepare for larger netdev_features_t type Michał Mirosław
2011-11-16 22:43 ` Ben Hutchings
2011-11-16 23:18 ` Michał Mirosław
2011-11-16 1:29 ` [PATCH v5 3/9] net: split netdev features to separate header Michał Mirosław
2011-11-16 2:14 ` Ben Hutchings
2011-11-16 1:29 ` [PATCH v5 1/9] net: remove legacy ethtool ops Michał Mirosław
2011-11-16 2:04 ` Ben Hutchings
2011-11-16 1:29 ` [PATCH v5 5/9] net: Define enum for net device features Michał Mirosław
2011-11-16 22:39 ` Ben Hutchings
2011-11-16 23:34 ` Michał Mirosław
2011-11-17 0:00 ` Ben Hutchings
2011-11-17 0:11 ` Michał Mirosław
2011-11-16 1:29 ` [PATCH v5 4/9] net: introduce and use netdev_features_t for device features sets Michał Mirosław
2011-11-16 22:30 ` Ben Hutchings
2011-11-16 1:29 ` [PATCH v5 8/9] net: extend netdev_features_t to 64 bits Michał Mirosław
2011-11-16 22:43 ` Ben Hutchings
2011-11-16 1:29 ` [PATCH v5 2/9] net: ethtool: break association of ETH_FLAG_* with NETIF_F_* Michał Mirosław
2011-11-16 2:06 ` Ben Hutchings [this message]
2011-11-16 22:49 ` [PATCH v5 0/9] Cleanup and extension of netdev features David Miller
2011-11-16 23:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321409205.2744.36.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).