From: Matti Vaittinen <matti.vaittinen@nsn.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: IPv6: Removing unnecessary NULL checks patch causes crash.
Date: Wed, 16 Nov 2011 11:51:59 +0200 [thread overview]
Message-ID: <1321437119.1858.105.camel@hakki> (raw)
I left my box to run some test scripts last night with net-next tree where patch
IPv6: Removing unnecessary NULL checks was applied. Crash had occurred when script
executed "ip route change xxx/128 dev eth0" with non existing target twice
in a row. (non existing target == there was no previous route to be changed)
This was not occuring with kernel where only
IPv6 routing, NLM_F_* flag support: REPLACE and EXCL flags support, warn about missing CREATE flag
and
IPv6 routing, NLM_F_* flag support: warn if new route is created without NLM_F_CREATE
were applied.
Anyways, I cannot think how info struct could be NULL, so I am a bit
puzzled. Looks like I am missing some piece here. Anyways, somewhere in
these patches is lurking a bug. I try to find the reason.
Sorry for the trouble.
--Matti
--
Matti Vaittinen
+358 504863070
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Told a UDP joke the other night...
...but I'm not sure everyone got it...
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
reply other threads:[~2011-11-16 9:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321437119.1858.105.camel@hakki \
--to=matti.vaittinen@nsn.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).