From: Ben Hutchings <bhutchings@solarflare.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Decotigny <david.decotigny@google.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Ian Campbell <ian.campbell@citrix.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Jiri Pirko <jpirko@redhat.com>, Joe Perches <joe@perches.com>,
Szymon Janc <szymon@janc.net.pl>,
Richard Jones <rick.jones2@hp.com>,
Ayaz Abdulla <AAbdulla@nvidia.com>
Subject: Re: [PATCH net-next v5 07/10] forcedeth: implement ndo_get_stats64() API
Date: Wed, 16 Nov 2011 17:14:54 +0000 [thread overview]
Message-ID: <1321463694.2709.1.camel@bwh-desktop> (raw)
In-Reply-To: <20111116085533.0982001e@s6510.linuxnetplumber.net>
On Wed, 2011-11-16 at 08:55 -0800, Stephen Hemminger wrote:
> On Tue, 15 Nov 2011 21:15:55 -0800
> David Decotigny <david.decotigny@google.com> wrote:
>
> > This commit implements the ndo_get_stats64() API for forcedeth. Since
> > these stats are being updated from different contexts (process and
> > timer), this commit adds protection (locking + atomic variables).
> >
> > Tested:
> > - 16-way SMP x86_64 ->
> > RX bytes:7244556582 (7.2 GB) TX bytes:181904254 (181.9 MB)
> > - pktgen + loopback: identical rx_bytes/tx_bytes and rx_packets/tx_packets
>
> Rather than adding additional locking why not use a percpu structure
> to hold statistics. See loopback, macvlan, veth, xen-netfront.
percpu is stupid for a single-queue driver.
> Or realize that the Tx side is single threaded by dev->xmit_lock already
> and the Rx side is single threaded by NAPI.
Right.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-11-16 17:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 5:15 [PATCH net-next v5 00/10] net-sysfs+forcedeth: stats & debug enhancements David Decotigny
2011-11-16 5:15 ` [PATCH net-next v5 01/10] forcedeth: fix stats on hardware without extended stats support David Decotigny
2011-11-16 5:15 ` [PATCH net-next v5 02/10] net-sysfs: fixed minor sparse warning David Decotigny
2011-11-16 5:15 ` [PATCH net-next v5 03/10] kbuild: document RPS/XPS network Kconfig options David Decotigny
2011-11-16 5:15 ` [PATCH net-next v5 04/10] net: provide counter for tx_timeout errors in sysfs David Decotigny
2011-11-16 16:51 ` Stephen Hemminger
2011-11-16 5:15 ` [PATCH net-next v5 05/10] forcedeth: Add messages to indicate using MSI or MSI-X David Decotigny
2011-11-16 5:15 ` [PATCH net-next v5 06/10] forcedeth: allow to silence "TX timeout" debug messages David Decotigny
2011-11-16 5:15 ` [PATCH net-next v5 07/10] forcedeth: implement ndo_get_stats64() API David Decotigny
2011-11-16 16:55 ` Stephen Hemminger
2011-11-16 17:14 ` Ben Hutchings [this message]
2011-11-16 19:25 ` David Decotigny
2011-11-16 19:32 ` Ben Hutchings
2011-11-16 20:32 ` Eric Dumazet
2011-11-16 20:46 ` David Decotigny
2011-11-16 5:15 ` [PATCH net-next v5 08/10] forcedeth: account for dropped RX frames David Decotigny
2011-11-16 5:15 ` [PATCH net-next v5 09/10] forcedeth: stats updated with a deferrable timer David Decotigny
2011-11-16 5:15 ` [PATCH net-next v5 10/10] forcedeth: whitespace/indentation fixes David Decotigny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321463694.2709.1.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=AAbdulla@nvidia.com \
--cc=davem@davemloft.net \
--cc=david.decotigny@google.com \
--cc=eric.dumazet@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=shemminger@vyatta.com \
--cc=szymon@janc.net.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).