* [PATCH] CDC NCM: Use kzalloc rather than kmalloc followed by memset with 0
@ 2011-11-17 22:43 Thomas Meyer
2011-11-22 20:58 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Meyer @ 2011-11-17 22:43 UTC (permalink / raw)
To: oliver, linux-usb, netdev, linux-kernel
This considers some simple cases that are common and easy to validate
Note in particular that there are no ...s in the rule, so all of the
matched code has to be contiguous
The semantic patch that makes this change is available
in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff -u -p a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
--- a/drivers/net/usb/cdc_ncm.c 2011-11-07 19:38:00.160137318 +0100
+++ b/drivers/net/usb/cdc_ncm.c 2011-11-08 09:35:34.632578608 +0100
@@ -465,12 +465,10 @@ static int cdc_ncm_bind(struct usbnet *d
int temp;
u8 iface_no;
- ctx = kmalloc(sizeof(*ctx), GFP_KERNEL);
+ ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
if (ctx == NULL)
return -ENODEV;
- memset(ctx, 0, sizeof(*ctx));
-
init_timer(&ctx->tx_timer);
spin_lock_init(&ctx->mtx);
ctx->netdev = dev->net;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] CDC NCM: Use kzalloc rather than kmalloc followed by memset with 0
2011-11-17 22:43 [PATCH] CDC NCM: Use kzalloc rather than kmalloc followed by memset with 0 Thomas Meyer
@ 2011-11-22 20:58 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-11-22 20:58 UTC (permalink / raw)
To: thomas; +Cc: oliver, linux-usb, netdev, linux-kernel
From: Thomas Meyer <thomas@m3y3r.de>
Date: Thu, 17 Nov 2011 23:43:40 +0100
> This considers some simple cases that are common and easy to validate
> Note in particular that there are no ...s in the rule, so all of the
> matched code has to be contiguous
>
> The semantic patch that makes this change is available
> in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-22 20:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-17 22:43 [PATCH] CDC NCM: Use kzalloc rather than kmalloc followed by memset with 0 Thomas Meyer
2011-11-22 20:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).