From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Joe Perches <joe@perches.com>
Cc: Intel Linux Wireless <ilw@linux.intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iwl-debug: Shrink object by using dev_err and deduplicating formats
Date: Thu, 17 Nov 2011 19:14:16 -0800 [thread overview]
Message-ID: <1321586056.11647.10.camel@wwguy-huron> (raw)
In-Reply-To: <1321580775.22117.8.camel@Joe-Laptop>
On Thu, 2011-11-17 at 17:46 -0800, Joe Perches wrote:
> Using dev_err instead of dev_printk(KERN_ERR uses fewer
> arguments and is a bit smaller.
>
> Deduplicating formats used by IWL_DEBUG_QUIET_RFKILL also
> makes the object a bit smaller.
>
> Neatened the macros, used ##__VA_ARGS__.
>
> $ size drivers/net/wireless/iwlwifi/built-in.o*
> text data bss dec hex filename
> 462652 8646 92576 563874 89aa2 drivers/net/wireless/iwlwifi/built-in.o.new
> 467557 8646 92592 568795 8addb drivers/net/wireless/iwlwifi/built-in.o.old
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> ---
> \
very interesting. Thanks
Wey
prev parent reply other threads:[~2011-11-18 4:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 1:46 [PATCH] iwl-debug: Shrink object by using dev_err and deduplicating formats Joe Perches
2011-11-18 3:14 ` Guy, Wey-Yi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321586056.11647.10.camel@wwguy-huron \
--to=wey-yi.w.guy@intel.com \
--cc=ilw@linux.intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).