From: Eric Dumazet <eric.dumazet@gmail.com>
To: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Cc: davem@davemloft.net, mcarlson@broadcom.com, mchan@broadcom.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] tg3: Fix advertisement handling
Date: Mon, 21 Nov 2011 07:38:13 +0100 [thread overview]
Message-ID: <1321857493.17419.5.camel@edumazet-laptop> (raw)
In-Reply-To: <20111121080720.0e68f096.shimoda.hiroaki@gmail.com>
Le lundi 21 novembre 2011 à 08:07 +0900, Hiroaki SHIMODA a écrit :
> Commit 28011cf19b (net: Add ethtool to mii advertisment conversion
> helpers) added a helper function ethtool_adv_to_mii_100bt() and
> tg3_copper_is_advertising_all(), tg3_phy_autoneg_cfg() were
> modified to use this.
> Before that commit, ethtool to mii advertisement conversion was
> done wrt speed, but now pause operation is also taken account.
> So, in tg3_copper_is_advertising_all(), below condition becomes
> true and this makes link up fails.
>
> if ((adv_reg & ADVERTISE_ALL) != all_mask)
> return 0;
>
> To fix this add ADVERTISE_ALL bit and operation to cap speed.
>
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Reported-and-tested-by: Eric Dumazet <eric.dumazet@gmail.com>
Thanks a lot !
next prev parent reply other threads:[~2011-11-21 6:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 23:07 [PATCH net-next] tg3: Fix advertisement handling Hiroaki SHIMODA
2011-11-21 6:38 ` Eric Dumazet [this message]
2011-11-21 19:29 ` Matt Carlson
2011-11-21 22:40 ` Hiroaki SHIMODA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321857493.17419.5.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=shimoda.hiroaki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox