Netdev List
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Ajit Khaparde <ajit.khaparde@emulex.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>
Subject: Re: [PATCH net-next 1/3] be2net: fix to display Pause autonegotiation setting
Date: Mon, 21 Nov 2011 17:10:45 +0000	[thread overview]
Message-ID: <1321895445.2692.3.camel@bwh-desktop> (raw)
In-Reply-To: <20111121051240.GA17132@akhaparde-VBox>

On Sun, 2011-11-20 at 23:12 -0600, Ajit Khaparde wrote:
> Pause autonegotiation is supported by default.
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
> ---
>  drivers/net/ethernet/emulex/benet/be_ethtool.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c
> index 575c783..ff53489 100644
> --- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
> +++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
> @@ -538,7 +538,7 @@ be_get_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *ecmd)
>  	struct be_adapter *adapter = netdev_priv(netdev);
>  
>  	be_cmd_get_flow_control(adapter, &ecmd->tx_pause, &ecmd->rx_pause);
> -	ecmd->autoneg = 0;
> +	ecmd->autoneg = 1;
>  }
>  
>  static int

This is surely not true for XFP and SFP+ interfaces.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

      reply	other threads:[~2011-11-21 17:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21  5:12 [PATCH net-next 1/3] be2net: fix to display Pause autonegotiation setting Ajit Khaparde
2011-11-21 17:10 ` Ben Hutchings [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321895445.2692.3.camel@bwh-desktop \
    --to=bhutchings@solarflare.com \
    --cc=ajit.khaparde@emulex.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox