netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next 1/3] be2net: fix to display Pause autonegotiation setting
@ 2011-11-21  5:12 Ajit Khaparde
  2011-11-21 17:10 ` Ben Hutchings
  0 siblings, 1 reply; 2+ messages in thread
From: Ajit Khaparde @ 2011-11-21  5:12 UTC (permalink / raw)
  To: netdev, davem

Pause autonegotiation is supported by default.

Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
---
 drivers/net/ethernet/emulex/benet/be_ethtool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c
index 575c783..ff53489 100644
--- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
+++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
@@ -538,7 +538,7 @@ be_get_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *ecmd)
 	struct be_adapter *adapter = netdev_priv(netdev);
 
 	be_cmd_get_flow_control(adapter, &ecmd->tx_pause, &ecmd->rx_pause);
-	ecmd->autoneg = 0;
+	ecmd->autoneg = 1;
 }
 
 static int
-- 
1.7.5.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next 1/3] be2net: fix to display Pause autonegotiation setting
  2011-11-21  5:12 [PATCH net-next 1/3] be2net: fix to display Pause autonegotiation setting Ajit Khaparde
@ 2011-11-21 17:10 ` Ben Hutchings
  0 siblings, 0 replies; 2+ messages in thread
From: Ben Hutchings @ 2011-11-21 17:10 UTC (permalink / raw)
  To: Ajit Khaparde; +Cc: netdev, davem

On Sun, 2011-11-20 at 23:12 -0600, Ajit Khaparde wrote:
> Pause autonegotiation is supported by default.
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
> ---
>  drivers/net/ethernet/emulex/benet/be_ethtool.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c
> index 575c783..ff53489 100644
> --- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
> +++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
> @@ -538,7 +538,7 @@ be_get_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *ecmd)
>  	struct be_adapter *adapter = netdev_priv(netdev);
>  
>  	be_cmd_get_flow_control(adapter, &ecmd->tx_pause, &ecmd->rx_pause);
> -	ecmd->autoneg = 0;
> +	ecmd->autoneg = 1;
>  }
>  
>  static int

This is surely not true for XFP and SFP+ interfaces.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-21 17:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-21  5:12 [PATCH net-next 1/3] be2net: fix to display Pause autonegotiation setting Ajit Khaparde
2011-11-21 17:10 ` Ben Hutchings

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).