netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jorge Boncompte [DTI2]" <jorge@dti2.net>
To: netdev@vger.kernel.org, linux-atm-general@lists.sourceforge.net
Cc: "Jorge Boncompte [DTI2]" <jorge@dti2.net>
Subject: [PATCH 1/5] atm: br2684: Do not move counters backwards
Date: Mon, 21 Nov 2011 21:25:54 +0100	[thread overview]
Message-ID: <1321907158-27857-2-git-send-email-jorge@dti2.net> (raw)
In-Reply-To: <1321907158-27857-1-git-send-email-jorge@dti2.net>

From: "Jorge Boncompte [DTI2]" <jorge@dti2.net>

    This snippet has caused several bugs in the past, and I don't see the
point on substracting the skb len from netdev stats.

Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net>
---
 net/atm/br2684.c |    9 +--------
 1 files changed, 1 insertions(+), 8 deletions(-)

diff --git a/net/atm/br2684.c b/net/atm/br2684.c
index d07223c..81cf33b 100644
--- a/net/atm/br2684.c
+++ b/net/atm/br2684.c
@@ -557,15 +557,8 @@ static int br2684_regvcc(struct atm_vcc *atmvcc, void __user * arg)
 	skb_queue_splice_init(rq, &queue);
 	spin_unlock_irqrestore(&rq->lock, flags);
 
-	skb_queue_walk_safe(&queue, skb, tmp) {
-		struct net_device *dev;
-
+	skb_queue_walk_safe(&queue, skb, tmp)
 		br2684_push(atmvcc, skb);
-		dev = skb->dev;
-
-		dev->stats.rx_bytes -= skb->len;
-		dev->stats.rx_packets--;
-	}
 
 	/* initialize netdev carrier state */
 	if (atmvcc->dev->signal == ATM_PHY_SIG_LOST)
-- 
1.7.7.1

  reply	other threads:[~2011-11-21 20:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21 20:25 [PATCH net-next 0/5] atm: cleanups and MSK_PEEK for atm sockets Jorge Boncompte [DTI2]
2011-11-21 20:25 ` Jorge Boncompte [DTI2] [this message]
2011-11-21 20:25 ` [PATCH 2/5] atm: clip: Don't move counters backwards Jorge Boncompte [DTI2]
2011-11-21 20:25 ` [PATCH 3/5] atm: clip: move clip_devs check to clip_push Jorge Boncompte [DTI2]
2011-11-21 20:25 ` [PATCH 4/5] atm: Introduce vcc_process_recv_queue Jorge Boncompte [DTI2]
2011-11-21 20:25 ` [PATCH 5/5] atm: Allow MSG_PEEK for atm sockets Jorge Boncompte [DTI2]
2011-11-22 21:16 ` [PATCH net-next 0/5] atm: cleanups and MSK_PEEK " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321907158-27857-2-git-send-email-jorge@dti2.net \
    --to=jorge@dti2.net \
    --cc=linux-atm-general@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).