From: Eric Dumazet <eric.dumazet@gmail.com>
To: Tom Herbert <therbert@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH v3 0/10] bql: Byte Queue Limits
Date: Wed, 23 Nov 2011 07:00:37 +0100 [thread overview]
Message-ID: <1322028037.1298.6.camel@edumazet-laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.1111222134590.9126@pokey.mtv.corp.google.com>
Le mardi 22 novembre 2011 à 21:52 -0800, Tom Herbert a écrit :
> Changes from last version:
> - Rebase to 3.2
> - Added CONFIG_BQL and CONFIG_DQL
> - Added some cache alignment in struct dql, to split read only, writeable
> elements, and split those elements written on transmit from those
> written at transmit completion (suggested by Eric).
> - Split out adding xps_queue_release as its own patch.
> - Some minor performance changes, use likely and unlikely for some
> conditionals.
> - Cleaned up some "show" functions for bql (pointed out by Ben).
> - Change netdev_tx_completed_queue to do check xoff, check
> availability, and then check xoff again. This to prevent potential
> race conditions with netdev_sent_queue (as Ben pointed out).
> - Did some more testing trying to evaluate overhead of BQL in the
> transmit path. I see about 1-3% degradation in CPU utilization
> and maximum pps when BQL is enabled. Any ideas to beat this
> down as much as possible would be appreciated!
> - Added high versus low priority traffic test to results below.
>
Excellent, I plan to review and test this today
Thanks !
next prev parent reply other threads:[~2011-11-23 6:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 5:52 [PATCH v3 0/10] bql: Byte Queue Limits Tom Herbert
2011-11-23 6:00 ` Eric Dumazet [this message]
2011-11-23 23:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322028037.1298.6.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox