From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
To: David Miller <davem@davemloft.net>
Cc: "lkml@hover.be" <lkml@hover.be>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: softirq oops from b44_poll
Date: Wed, 23 Nov 2011 00:13:10 -0800 [thread overview]
Message-ID: <1322035990.29851.0.camel@ppwaskie-mobl2> (raw)
In-Reply-To: <20111122.155426.1153643155035648664.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 641 bytes --]
On Tue, 2011-11-22 at 12:54 -0800, David Miller wrote:
> From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Date: Mon, 21 Nov 2011 15:17:33 -0800
>
> > I suspect the "right" way to fix this is to call dev_kfree_skb_any(skb);
> > instead, since that will handle the in-interrupt case if that's where
> > we're stuck.
>
> Caller is always b44_poll(), and that caller always does spin_lock_irqsave().
>
> Adding the extra tests implied by dev_kfree_skb_any() therefore doesn't
> make any sense, as it will always evaluate to dev_kfree_skb_irq().
Agreed, I didn't dig enough through the code. Thanks Dave.
-PJ
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 4394 bytes --]
next prev parent reply other threads:[~2011-11-23 8:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAJfGthSxanFbL2vKCpOQbP9K5oNAxeaYt7OMdmdoCb4eLQ_Fww@mail.gmail.com>
2011-11-21 23:17 ` softirq oops from b44_poll Peter P Waskiewicz Jr
2011-11-22 13:43 ` Xander Hover
2011-11-22 20:54 ` David Miller
2011-11-22 23:16 ` Xander Hover
2011-11-23 8:14 ` Peter P Waskiewicz Jr
2011-11-23 8:13 ` Peter P Waskiewicz Jr [this message]
2011-11-07 20:56 Josh Boyer
2011-11-08 6:21 ` Peter P Waskiewicz Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322035990.29851.0.camel@ppwaskie-mobl2 \
--to=peter.p.waskiewicz.jr@intel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@hover.be \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).