From: Neil Horman <nhorman@tuxdriver.com>
To: netdev@vger.kernel.org
Cc: Neil Horman <nhorman@tuxdriver.com>,
Kirill Smelkov <kirr@mns.spb.ru>,
"David S. Miller" <davem@davemloft.net>,
john.r.fastabend@intel.com, robert.w.love@intel.com,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org
Subject: [PATCH] netprio_cgroup: Fix build break
Date: Wed, 23 Nov 2011 07:32:33 -0500 [thread overview]
Message-ID: <1322051553-28987-1-git-send-email-nhorman@tuxdriver.com> (raw)
I broke the build with the addition of netprio_cgroups if CONFIG_CGROUPS=n.
This patch corrects it by moving the offending struct into an ifdef
CONFIG_CGROUPS block. Also clean up a few needless defines and inline functions
that don't get called if CONFIG_CGROUPS isn't defined while Im at it.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: Kirill Smelkov <kirr@mns.spb.ru>
CC: "David S. Miller" <davem@davemloft.net>
CC: john.r.fastabend@intel.com
CC: robert.w.love@intel.com
CC: Stephen Rothwell <sfr@canb.auug.org.au>
CC: linux-next@vger.kernel.org
---
include/net/netprio_cgroup.h | 18 +++++-------------
1 files changed, 5 insertions(+), 13 deletions(-)
diff --git a/include/net/netprio_cgroup.h b/include/net/netprio_cgroup.h
index c432e99..e503b87 100644
--- a/include/net/netprio_cgroup.h
+++ b/include/net/netprio_cgroup.h
@@ -18,11 +18,6 @@
#include <linux/hardirq.h>
#include <linux/rcupdate.h>
-struct cgroup_netprio_state
-{
- struct cgroup_subsys_state css;
- u32 prioidx;
-};
struct netprio_map {
struct rcu_head rcu;
@@ -32,6 +27,11 @@ struct netprio_map {
#ifdef CONFIG_CGROUPS
+struct cgroup_netprio_state {
+ struct cgroup_subsys_state css;
+ u32 prioidx;
+};
+
#ifndef CONFIG_NETPRIO_CGROUP
extern int net_prio_subsys_id;
#endif
@@ -52,14 +52,6 @@ static inline struct cgroup_netprio_state
#else
#define sock_update_netprioidx(sk)
-#define skb_update_prio(skb)
-
-static inline struct cgroup_netprio_state
- *task_netprio_state(struct task_struct *p)
-{
- return NULL;
-}
-
#endif
#endif /* _NET_CLS_CGROUP_H */
--
1.7.6.4
next reply other threads:[~2011-11-23 12:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 12:32 Neil Horman [this message]
2011-11-23 13:11 ` [PATCH] netprio_cgroup: Fix build break Kirill Smelkov
2011-11-23 14:22 ` Neil Horman
2011-11-23 20:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322051553-28987-1-git-send-email-nhorman@tuxdriver.com \
--to=nhorman@tuxdriver.com \
--cc=davem@davemloft.net \
--cc=john.r.fastabend@intel.com \
--cc=kirr@mns.spb.ru \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robert.w.love@intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).