Re: drivers/net: Kconfig & Makefile cleanup

Re: drivers/net: Kconfig & Makefile cleanup

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

You wrote that (some time ago now):
> As a side cleanup, found that the arcnet, token ring, and PHY
> Kconfig options were a tri-state option and should have been
> a bool option.

How did you decide that?  This seems to be correct for TR, but ARCNET
and PHYLIB each select some support code that can be built as a module
(and which has been, in Debian).

Ben.

-- 
Ben Hutchings
Teamwork is essential - it allows you to blame someone else.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: drivers/net: Kconfig & Makefile cleanup

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

You wrote that (some time ago now):
> As a side cleanup, found that the arcnet, token ring, and PHY
> Kconfig options were a tri-state option and should have been
> a bool option.

How did you decide that?  This seems to be correct for TR, but ARCNET
and PHYLIB each select some support code that can be built as a module
(and which has been, in Debian).

Ben.

-- 
Ben Hutchings
Teamwork is essential - it allows you to blame someone else.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: drivers/net: Kconfig & Makefile cleanup

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]

On Mon, 2011-11-21 at 22:51 -0800, Ben Hutchings wrote:
> ou wrote that (some time ago now):
> > As a side cleanup, found that the arcnet, token ring, and PHY
> > Kconfig options were a tri-state option and should have been
> > a bool option.
> 
> How did you decide that?  This seems to be correct for TR, but ARCNET
> and PHYLIB each select some support code that can be built as a module
> (and which has been, in Debian).
> 
> Ben. 

Off the top of my head, I was making the decision based on the other
protocols Kconfig entries.

So does that mean ARCNET could be a module and a driver using ARCNET
would have to be a module as well?

I will take a look at this to come up with a solution, if one has not
been sent out yet.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: drivers/net: Kconfig & Makefile cleanup

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

You wrote that (some time ago now):
> As a side cleanup, found that the arcnet, token ring, and PHY
> Kconfig options were a tri-state option and should have been
> a bool option.

How did you decide that?  This seems to be correct for TR, but ARCNET
and PHYLIB each select some support code that can be built as a module
(and which has been, in Debian).

Ben.

-- 
Ben Hutchings
Teamwork is essential - it allows you to blame someone else.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: drivers/net: Kconfig & Makefile cleanup

[Randy Dunlap]

On 11/21/2011 10:49 PM, Ben Hutchings wrote:
> You wrote that (some time ago now):
>> As a side cleanup, found that the arcnet, token ring, and PHY
>> Kconfig options were a tri-state option and should have been
>> a bool option.
> 
> How did you decide that?  This seems to be correct for TR, but ARCNET
> and PHYLIB each select some support code that can be built as a module
> (and which has been, in Debian).

For CONFIG_TR, it causes some build errors in snap & llc, but that is
due to a kconfig problem for which there is a test patch (not merged
anywhere).

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***