From: jamal <hadi-fAAogVwAN2Kw5LPnMra/2Q@public.gmane.org>
To: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org,
chrisw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Florian Westphal <fw-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org>,
john.r.fastabend-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
herbert-F6s6mLieUQo7FNHlEwC/lvQIK84fMopw@public.gmane.org,
shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Subject: Re: Open vSwitch Design
Date: Fri, 25 Nov 2011 06:34:22 -0500 [thread overview]
Message-ID: <1322220862.1908.79.camel@mojatatu> (raw)
In-Reply-To: <1322203013.2872.28.camel@edumazet-laptop>
Hrm. I forgot about the flow classifier - it may be what the openflow
folks need. It is more friendly for the well defined tuples than u32.
But what do you mean "refactor"? I can already use this classifier
and attach actions to set policy in the kernel.
cheers,
jamal
On Fri, 2011-11-25 at 07:36 +0100, Eric Dumazet wrote:
> > >
> > > Maybe its time to factorize the thing, eventually use it in a third
> > > component (Open vSwitch...)
> >
> > Yes.
>
> A third reason to do that anyway is that net/sched/sch_sfb.c should use
> __skb_get_rxhash() providing the perturbation itself, and not use the
> standard (hashrnd) one ).
>
> Right now, if two flows share same rxhash, the double SFB hash will also
> share the same final hash.
>
> (This point was mentioned by Florian Westphal)
>
>
>
next prev parent reply other threads:[~2011-11-25 11:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 20:10 Open vSwitch Design Jesse Gross
[not found] ` <CAEP_g=_2L1xFWtDXh_6YyXz1Mt9TR3zvjLzix+SpO6yzeOLsSQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-24 22:30 ` jamal
2011-11-25 5:20 ` Stephen Hemminger
[not found] ` <20111124212021.2ae2fb7f-QE31Isp8l5DVJhW05BI4jyWSNWFUUkiGXqFh9Ls21Oc@public.gmane.org>
2011-11-25 6:18 ` Eric Dumazet
2011-11-25 6:25 ` David Miller
[not found] ` <20111125.012517.2221372383643417980.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2011-11-25 6:36 ` Eric Dumazet
2011-11-25 11:34 ` jamal [this message]
2011-11-25 13:02 ` Eric Dumazet
2011-11-28 15:20 ` [PATCH net-next 0/4] net: factorize flow dissector Eric Dumazet
2011-11-25 20:20 ` Open vSwitch Design Jesse Gross
[not found] ` <CAEP_g=9tcH9kJrVsHc26kXWZEUS8G-U=U7y6k8xaZG5MD0OTyg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-26 1:23 ` Jamal Hadi Salim
2011-11-25 20:14 ` Jesse Gross
2011-11-25 11:24 ` jamal
2011-11-25 17:28 ` Stephen Hemminger
2011-11-25 17:55 ` Jesse Gross
2011-11-25 19:52 ` Justin Pettit
[not found] ` <2DB44B16-598F-4414-8B35-8E322D705A9A-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
2011-11-26 1:11 ` Jamal Hadi Salim
2011-11-26 4:38 ` Stephen Hemminger
[not found] ` <ec23d63d-27c9-4761-bdd3-e3f54bdb5e77-bX68f012229Xuxj3zoTs5AC/G2K4zDHf@public.gmane.org>
2011-11-26 8:05 ` Martin Casado
2011-11-28 18:34 ` Justin Pettit
2011-11-28 22:42 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322220862.1908.79.camel@mojatatu \
--to=hadi-faaogvwan2kw5lpnmra/2q@public.gmane.org \
--cc=chrisw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org \
--cc=eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=fw-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org \
--cc=herbert-F6s6mLieUQo7FNHlEwC/lvQIK84fMopw@public.gmane.org \
--cc=jhs-jkUAjuhPggJWk0Htik3J/w@public.gmane.org \
--cc=john.r.fastabend-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).