Re: [PATCH net] net: Revert ARCNET and PHYLIB to tristate options

[Ben Hutchings <ben@decadent.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

On Fri, 2011-11-25 at 01:31 -0500, David Miller wrote:
> From: Ben Hutchings <ben@decadent.org.uk>
> Date: Thu, 24 Nov 2011 07:23:30 +0000
> 
> > Commit 88491d8103498a6166f70d5999902fec70924314 ("drivers/net: Kconfig
> > & Makefile cleanup") changed the type of these options to bool, but
> > they select code that could (and still can) be built as modules.
> > 
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > ---
> > I consider the inability to build arcnet.o and libphy.o as modules to be
> > a regression in 3.2 for general-purpose distribution kernels.
> > Therefore, please apply this to the net tree.
> 
> I challenge you to get PHYLIB set to 'm' in a configuration such as
> "allmodconfig" which is clearly in line with the kind of configuration
> which "distribution kernels" use.
[...]

Well, I can't think why it would be built in, since PHY modules can be
auto-loaded now.

$ grep PHYLIB /boot/config-2.6.32-5-amd64 
CONFIG_PHYLIB=m
$ grep PHYLIB /boot/config-3.1.0-1-amd64 
CONFIG_PHYLIB=m

Ben.

-- 
Ben Hutchings
Teamwork is essential - it allows you to blame someone else.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]