From: Ben Hutchings <ben@decadent.org.uk>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/8] dsa: Export functions from core to modules
Date: Sun, 27 Nov 2011 22:38:57 +0000 [thread overview]
Message-ID: <1322433537.7454.32.camel@deadeye> (raw)
In-Reply-To: <20111127191556.GQ795@wantstofly.org>
[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]
On Sun, 2011-11-27 at 20:15 +0100, Lennert Buytenhek wrote:
[...]
> > diff --git a/net/dsa/slave.c b/net/dsa/slave.c
> > index 56cf9b8..c9d52ca 100644
> > --- a/net/dsa/slave.c
> > +++ b/net/dsa/slave.c
> > @@ -45,6 +45,7 @@ void dsa_slave_mii_bus_init(struct dsa_switch *ds)
> > ds->master_mii_bus->id, ds->pd->sw_addr);
> > ds->slave_mii_bus->parent = &ds->master_mii_bus->dev;
> > }
> > +EXPORT_SYMBOL_GPL(dsa_slave_mii_bus_init);
> >
> >
> > /* slave device handling ****************************************************/
> > @@ -402,3 +403,4 @@ dsa_slave_create(struct dsa_switch *ds, struct device *parent,
> >
> > return slave_dev;
> > }
> > +EXPORT_SYMBOL_GPL(dsa_slave_create);
>
> Why do these need to be exported? They are only called from dsa.c,
> and dsa.c and slave.c are always linked into the same entity, even
> after your patches.
Oh, yes. I just failed to revert these exports when I decided they
should be linked together.
Ben.
--
Ben Hutchings
The two most common things in the universe are hydrogen and stupidity.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2011-11-27 22:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-26 0:32 [PATCH net-next 1/8] dsa: Change dsa_uses_{dsa,trailer}_tags() into inline functions Ben Hutchings
2011-11-26 0:34 ` [PATCH net-next 2/8] dsa: Export functions from core to modules Ben Hutchings
2011-11-27 19:15 ` Lennert Buytenhek
2011-11-27 22:38 ` Ben Hutchings [this message]
2011-11-26 0:35 ` [PATCH net-next 3/8] dsa: Combine core and tagging code Ben Hutchings
2011-11-27 19:16 ` Lennert Buytenhek
2011-11-26 0:36 ` [PATCH net-next 4/8] mv88e6xxx: Combine mv88e6131 and mv88e612_61_65 drivers Ben Hutchings
2011-11-27 19:18 ` Lennert Buytenhek
2011-11-26 0:37 ` [PATCH net-next 5/8] dsa: Define module author, description, license and aliases for drivers Ben Hutchings
2011-11-27 19:17 ` Lennert Buytenhek
2011-11-26 0:38 ` [PATCH net-next 6/8] dsa: Allow core and drivers to be built as modules Ben Hutchings
2011-11-27 19:19 ` Lennert Buytenhek
2011-11-27 22:39 ` Ben Hutchings
2011-11-26 0:40 ` [PATCH net-next 7/8] net: Revert ARCNET and PHYLIB to tristate options Ben Hutchings
2011-11-26 19:42 ` David Miller
2011-11-26 0:40 ` [PATCH net-next 8/8] net: Use IS_ENABLED() in netdevice.h as appropriate Ben Hutchings
2011-11-27 19:12 ` [PATCH net-next 1/8] dsa: Change dsa_uses_{dsa,trailer}_tags() into inline functions Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322433537.7454.32.camel@deadeye \
--to=ben@decadent.org.uk \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).