From: Ben Hutchings <ben@decadent.org.uk>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 6/8] dsa: Allow core and drivers to be built as modules
Date: Sun, 27 Nov 2011 22:39:24 +0000 [thread overview]
Message-ID: <1322433564.7454.33.camel@deadeye> (raw)
In-Reply-To: <20111127191955.GU795@wantstofly.org>
[-- Attachment #1: Type: text/plain, Size: 985 bytes --]
On Sun, 2011-11-27 at 20:19 +0100, Lennert Buytenhek wrote:
> On Sat, Nov 26, 2011 at 12:38:38AM +0000, Ben Hutchings wrote:
>
> > Change the kconfig types to tristate and adjust the condition for
> > declaring net_device::dsa_ptr to allow for this.
> >
> > Adjust the makefile so that if NET_DSA_MV88E6123_61_65=y and
> > NET_DSA_MV88E6131=m or vice versa then both drivers are built-in. We
> > could leave these options as bool and make NET_DSA_MV88E6XXX a
> > user-selected option, but that would break existing configurations.
> >
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
>
> Acked-by: Lennert Buytenhek <buytenh@wantstofly.org>
>
> Thanks for the patches!
>
> (While you're at it -- the switch chip drivers in net/dsa/ still
> ought to be moved to drivers/net/dsa/ or so -- feel like whipping up
> a patch for that?)
I agree. Maybe.
Ben.
--
Ben Hutchings
The two most common things in the universe are hydrogen and stupidity.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2011-11-27 22:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-26 0:32 [PATCH net-next 1/8] dsa: Change dsa_uses_{dsa,trailer}_tags() into inline functions Ben Hutchings
2011-11-26 0:34 ` [PATCH net-next 2/8] dsa: Export functions from core to modules Ben Hutchings
2011-11-27 19:15 ` Lennert Buytenhek
2011-11-27 22:38 ` Ben Hutchings
2011-11-26 0:35 ` [PATCH net-next 3/8] dsa: Combine core and tagging code Ben Hutchings
2011-11-27 19:16 ` Lennert Buytenhek
2011-11-26 0:36 ` [PATCH net-next 4/8] mv88e6xxx: Combine mv88e6131 and mv88e612_61_65 drivers Ben Hutchings
2011-11-27 19:18 ` Lennert Buytenhek
2011-11-26 0:37 ` [PATCH net-next 5/8] dsa: Define module author, description, license and aliases for drivers Ben Hutchings
2011-11-27 19:17 ` Lennert Buytenhek
2011-11-26 0:38 ` [PATCH net-next 6/8] dsa: Allow core and drivers to be built as modules Ben Hutchings
2011-11-27 19:19 ` Lennert Buytenhek
2011-11-27 22:39 ` Ben Hutchings [this message]
2011-11-26 0:40 ` [PATCH net-next 7/8] net: Revert ARCNET and PHYLIB to tristate options Ben Hutchings
2011-11-26 19:42 ` David Miller
2011-11-26 0:40 ` [PATCH net-next 8/8] net: Use IS_ENABLED() in netdevice.h as appropriate Ben Hutchings
2011-11-27 19:12 ` [PATCH net-next 1/8] dsa: Change dsa_uses_{dsa,trailer}_tags() into inline functions Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322433564.7454.33.camel@deadeye \
--to=ben@decadent.org.uk \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).