Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Пламен Петров" <plamen.sisi@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [NET][TG3] Fwd: page allocation failure with linux 3.1.1
Date: Mon, 28 Nov 2011 09:26:02 +0100	[thread overview]
Message-ID: <1322468762.2826.17.camel@edumazet-laptop> (raw)
In-Reply-To: <CALkh-Hi=Pb_cNUzHrJSe4o5-kmb+jLA8vpw8hiaGxROzNJ6oag@mail.gmail.com>

Le lundi 28 novembre 2011 à 09:16 +0200, Пламен Петров a écrit :

> Well, Eric, thanks for the explanation! I will disable TSO and will
> see how is that working out for me - if I recall correctly, I had no
> problems when TSO was off.
> 
> Sorry to bother you, if the above explanation was somewhere readily
> available, but I didn't manage to find it.

You dont bother me at all :)

As a matter of fact, your mail reminded me something I wanted to do in
the past and forgot about.

Since some devices might copy skb to a linear one in their
ndo_start_xmit(), we could set a netdev limit so that TSO can still be
used on these devices, but limiting number of frags to
2^PAGE_ALLOC_COSTLY_ORDER

(Since PAGE_ALLOC_COSTLY_ORDER == 3, thats 8 frags, instead of 16 right
now on x86)

Of course, if memory is really tight, even an ATOMIC order-3 allocation
might fail. If this happens, device limit could be dynamically
decreased. In the end, only linear skb could be built by TCP.

  reply	other threads:[~2011-11-28  8:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CALkh-HhkzHb7-2LAwCNOZ-S4otfeM+tthyw2_XDbDUjFRSkKjA@mail.gmail.com>
2011-11-27 20:34 ` [NET][TG3] Fwd: page allocation failure with linux 3.1.1 Пламен Петров
2011-11-28  6:35   ` Eric Dumazet
2011-11-28  7:16     ` Пламен Петров
2011-11-28  8:26       ` Eric Dumazet [this message]
2011-11-28 19:05         ` Rick Jones
2011-11-28 19:28           ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322468762.2826.17.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=plamen.sisi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox