From: Joe Perches <joe@perches.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: "Eric Dumazet" <eric.dumazet@gmail.com>,
"David Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH net-next] tcp: tcp_sendmsg() wrong access to sk_route_caps
Date: Mon, 28 Nov 2011 09:32:57 -0800 [thread overview]
Message-ID: <1322501577.2024.34.camel@Joe-Laptop> (raw)
In-Reply-To: <1322500843.26733.2.camel@bwh-desktop>
On Mon, 2011-11-28 at 17:20 +0000, Ben Hutchings wrote:
> On Mon, 2011-11-28 at 08:54 -0800, Joe Perches wrote:
> > Perhaps a checkpatch warning should be issued
> > when the implicit cast [to bool] is used.
> checkpatch can't do type-checking; maybe you mean sparse.
I think I could get checkpatch to track the bool
type implicit casts for the not struct member
uses of bool.
ie:
bool foo;
[...]
foo = expr;
but not:
struct foo {
bool bar;
};
[...]
foo.bar = expr;
It's pretty trivial to do it mostly correctly
with spatch/cocci though.
next prev parent reply other threads:[~2011-11-28 17:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 10:27 [PATCH net-next] tcp: tcp_sendmsg() wrong access to sk_route_caps Eric Dumazet
2011-11-28 10:46 ` Joe Perches
2011-11-28 16:04 ` Eric Dumazet
2011-11-28 16:53 ` David Laight
2011-11-28 16:54 ` Joe Perches
2011-11-28 17:20 ` Ben Hutchings
2011-11-28 17:32 ` Joe Perches [this message]
2011-11-28 23:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322501577.2024.34.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox