Re: [PATCH v3 02/10] net: Add queue state xoff flag for stack

[Ben Hutchings <bhutchings@solarflare.com>]

On Tue, 2011-11-22 at 21:52 -0800, Tom Herbert wrote:
> Create separate queue state flags so that either the stack or drivers
> can turn on XOFF.  Added a set of functions used in the stack to determine
> if a queue is really stopped (either by stack or driver)
[...]
>  static inline int netif_tx_queue_stopped(const struct netdev_queue *dev_queue)
>  {
> -	return test_bit(__QUEUE_STATE_XOFF, &dev_queue->state);
> +	return test_bit(__QUEUE_STATE_DRV_XOFF, &dev_queue->state);
>  }
[...]
> +static inline int netif_xmit_stopped(const struct netdev_queue *dev_queue)
>  {
> -	return dev_queue->state & QUEUE_STATE_XOFF_OR_FROZEN;
> +	return dev_queue->state & QUEUE_STATE_ANY_XOFF;
> +}
[...]

The difference in names here doesn't really suggest the difference in
semantics.  I think they will be easy to confuse.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.