From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: <jdelvare@suse.de>, <netdev@vger.kernel.org>,
<thockin@hockin.org>, <okir@suse.de>
Subject: Re: [PATCH] natsemi: make cable length magic configurable
Date: Mon, 28 Nov 2011 17:51:04 +0000 [thread overview]
Message-ID: <1322502664.26733.9.camel@bwh-desktop> (raw)
In-Reply-To: <20111125.013713.1783082973236989821.davem@davemloft.net>
On Fri, 2011-11-25 at 01:37 -0500, David Miller wrote:
> From: Jean Delvare <jdelvare@suse.de>
> Date: Thu, 24 Nov 2011 14:43:59 +0100
>
> > We had a customer report concerning problems with a Natsemi DP83815-D
> > and long cables. With 100m cables, the network would be essentially dead,
> > not a single packet would get through either way. We had to apply the
> > patch below to make it work.
>
> Please do not add new private device driver module knobs.
>
> Instead, add generic flags to the ethtool interface or similar to
> control device behavior.
This isn't a generic flag; it seems to be a workaround for a specific
bug that unfortunately can't be automatic.
That's why I suggested an ethtool private flag.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-11-28 17:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 13:43 [PATCH] natsemi: make cable length magic configurable Jean Delvare
2011-11-24 19:25 ` Ben Hutchings
2012-07-16 12:26 ` Jean Delvare
2012-07-16 13:08 ` Ben Hutchings
2012-07-16 13:57 ` Mark Brown
2012-07-17 5:22 ` David Miller
2011-11-25 6:37 ` David Miller
2011-11-28 17:51 ` Ben Hutchings [this message]
2011-11-28 21:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322502664.26733.9.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=jdelvare@suse.de \
--cc=netdev@vger.kernel.org \
--cc=okir@suse.de \
--cc=thockin@hockin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).