From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH] natsemi: make cable length magic configurable Date: Mon, 28 Nov 2011 17:51:04 +0000 Message-ID: <1322502664.26733.9.camel@bwh-desktop> References: <201111241443.59191.jdelvare@suse.de> <20111125.013713.1783082973236989821.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: , , , To: David Miller Return-path: Received: from mail.solarflare.com ([216.237.3.220]:48268 "EHLO ocex02.SolarFlarecom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750878Ab1K1RvI (ORCPT ); Mon, 28 Nov 2011 12:51:08 -0500 In-Reply-To: <20111125.013713.1783082973236989821.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 2011-11-25 at 01:37 -0500, David Miller wrote: > From: Jean Delvare > Date: Thu, 24 Nov 2011 14:43:59 +0100 > > > We had a customer report concerning problems with a Natsemi DP83815-D > > and long cables. With 100m cables, the network would be essentially dead, > > not a single packet would get through either way. We had to apply the > > patch below to make it work. > > Please do not add new private device driver module knobs. > > Instead, add generic flags to the ethtool interface or similar to > control device behavior. This isn't a generic flag; it seems to be a workaround for a specific bug that unfortunately can't be automatic. That's why I suggested an ethtool private flag. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.