From: jamal <hadi@cyberus.ca>
To: Tom Herbert <therbert@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH v4 02/10] net: Add queue state xoff flag for stack
Date: Tue, 29 Nov 2011 08:12:51 -0500 [thread overview]
Message-ID: <1322572371.2090.1.camel@mojatatu> (raw)
In-Reply-To: <alpine.DEB.2.00.1111281816540.24308@pokey.mtv.corp.google.com>
On Mon, 2011-11-28 at 18:32 -0800, Tom Herbert wrote:
>
> enum netdev_queue_state_t {
> - __QUEUE_STATE_XOFF,
> + __QUEUE_STATE_DRV_XOFF,
> + __QUEUE_STATE_STACK_XOFF,
> __QUEUE_STATE_FROZEN,
QUEUE_STATE_DRV_XOFF seems to be a rename of __QUEUE_STATE_XOFF
no issues there.
Is inserting __QUEUE_STATE_STACK_XOFF going to cause any issues?
Typically, you should insert new things at the end.
cheers,
jamal
next prev parent reply other threads:[~2011-11-29 13:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 2:32 [PATCH v4 02/10] net: Add queue state xoff flag for stack Tom Herbert
2011-11-29 13:12 ` jamal [this message]
2011-11-29 17:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322572371.2090.1.camel@mojatatu \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).