netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Dave Taht <dave.taht@gmail.com>,
	Tom Herbert <therbert@google.com>, <davem@davemloft.net>,
	<netdev@vger.kernel.org>
Subject: Re: [PATCH v4 0/10] bql: Byte Queue Limits
Date: Tue, 29 Nov 2011 14:24:05 +0000	[thread overview]
Message-ID: <1322576645.7454.48.camel@deadeye> (raw)
In-Reply-To: <1322550138.2970.70.camel@edumazet-laptop>

On Tue, 2011-11-29 at 08:02 +0100, Eric Dumazet wrote:
> Le mardi 29 novembre 2011 à 05:23 +0100, Dave Taht a écrit :
> > > In this test 100 netperf TCP_STREAMs were started to saturate the link.
> > > A single instance of a netperf TCP_RR was run with high priority set.
> > > Queuing discipline in pfifo_fast, NIC is e1000 with TX ring size set to
> > > 1024.  tps for the high priority RR is listed.
> > >
> > > No BQL, tso on: 3000-3200K bytes in queue: 36 tps
> > > BQL, tso on: 156-194K bytes in queue, 535 tps
> > 
> > > No BQL, tso off: 453-454K bytes int queue, 234 tps
> > > BQL, tso off: 66K bytes in queue, 914 tps
> > 
> > 
> > Jeeze. Under what circumstances is tso a win? I've always
> > had great trouble with it, as some e1000 cards do it rather badly.
> > 
> > I assume these are while running at GigE speeds?
> > 
> > What of 100Mbit? 10GigE? (I will duplicate your tests
> > at 100Mbit, but as for 10gigE...)
> > 
> 
> TSO on means a low priority 65Kbytes packet can be in TX ring right
> before the high priority packet. If you cant afford the delay, you lose.
> 
> There is no mystery here.
> 
> If you want low latencies :
> - TSO must be disabled so that packets are at most one ethernet frame. 
[...]

Not if you separate hardware queues by priority (and your high priority
packets are non-TCP or PuSHed).

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

  parent reply	other threads:[~2011-11-29 14:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29  2:32 [PATCH v4 0/10] bql: Byte Queue Limits Tom Herbert
2011-11-29  4:23 ` Dave Taht
2011-11-29  7:02   ` Eric Dumazet
2011-11-29  7:07     ` Eric Dumazet
2011-11-29  7:23     ` John Fastabend
2011-11-29  7:45       ` Eric Dumazet
2011-11-29  8:03         ` John Fastabend
2011-11-29  8:37       ` Dave Taht
2011-11-29  8:43         ` Eric Dumazet
2011-11-29  8:51           ` Dave Taht
2011-11-29 14:57             ` Eric Dumazet
2011-11-29 16:24               ` Dave Taht
2011-11-29 17:06                 ` David Laight
2011-11-29 14:24     ` Ben Hutchings [this message]
2011-11-29 14:29       ` Eric Dumazet
2011-11-29 16:06         ` Dave Taht
2011-11-29 16:41           ` Ben Hutchings
2011-11-29 17:28     ` Rick Jones
2011-11-29 16:46 ` Eric Dumazet
2011-11-29 17:47   ` David Miller
2011-11-29 18:31     ` Tom Herbert
2011-12-01 16:50       ` Kirill Smelkov
2011-12-01 18:00         ` David Miller
2011-12-02 11:22           ` Kirill Smelkov
2011-12-02 11:57             ` Eric Dumazet
2011-12-02 12:26               ` Kirill Smelkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322576645.7454.48.camel@deadeye \
    --to=bhutchings@solarflare.com \
    --cc=dave.taht@gmail.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).