From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Hagen Paul Pfeifer <hagen@jauu.net>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: RE: [PATCH net-next] netem: fix build error on 32bit arches
Date: Thu, 01 Dec 2011 12:19:15 +0100 [thread overview]
Message-ID: <1322738355.2335.26.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6D8AEF7@saturn3.aculab.com>
Le jeudi 01 décembre 2011 à 11:04 +0000, David Laight a écrit :
> > + u64 ticks = (u64)len * NSEC_PER_SEC;
> Writing:
> u64 ticks = len * (u64)NSEC_PER_SEC;
> probably generates better code since the compiler
> is much more likely to spot that a single 32x32 -> 64
> multiply is adequate.
>
Your copy if gcc is very dumb then :)
next prev parent reply other threads:[~2011-12-01 11:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 22:20 [PATCH v3 net-next 1/2] netem: rate extension Hagen Paul Pfeifer
2011-11-30 22:20 ` [PATCH v3 net-next 2/2] netem: add cell concept to simulate special MAC behavior Hagen Paul Pfeifer
2011-12-01 3:30 ` Eric Dumazet
2011-12-01 8:25 ` Hagen Paul Pfeifer
2011-12-01 9:01 ` Eric Dumazet
2011-12-01 9:32 ` [PATCH net-next] netem: fix build error on 32bit arches Eric Dumazet
2011-12-01 9:46 ` Hagen Paul Pfeifer
2011-12-01 11:04 ` David Laight
2011-12-01 11:19 ` Eric Dumazet [this message]
2011-12-01 17:46 ` David Miller
2011-12-01 9:36 ` [PATCH v3 net-next 2/2] netem: add cell concept to simulate special MAC behavior Hagen Paul Pfeifer
2011-12-01 16:24 ` Stephen Hemminger
2011-12-01 16:38 ` David Laight
2011-12-01 16:57 ` Stephen Hemminger
2011-12-01 18:25 ` Rick Jones
2011-12-01 4:19 ` [PATCH v3 net-next 1/2] netem: rate extension David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322738355.2335.26.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC \
--to=eric.dumazet@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=hagen@jauu.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox