From: Joe Perches <joe@perches.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] nfc: Use standard logging styles
Date: Thu, 01 Dec 2011 10:48:38 -0800 [thread overview]
Message-ID: <1322765318.30801.9.camel@joe2Laptop> (raw)
In-Reply-To: <20111201155951.GF22609@sortiz-mobl>
On Thu, 2011-12-01 at 16:59 +0100, Samuel Ortiz wrote:
> Hi Joe,
Hello Samuel.
> On Tue, Nov 29, 2011 at 11:37:32AM -0800, Joe Perches wrote:
> > Using the normal logging styles is preferred over
> > subsystem specific styles when the subsystem does
> > not take a specific struct.
> > Convert nfc_<level> specific messages to pr_<level>
> > Add newlines to uses.
> I would be fine with moving to pr_debug, but I'd like the pr_fmt() routine to
> include the function name as well.
If you really want it I can add it back but
if you are not aware, dynamic debug can add
this by using:
echo "module nfc +fp" > <debugfs>/dynamic_debug/control
echo "module nci +fp" > <debugfs>/dynamic_debug/control
If you're getting dmesg logs from customers
that's a bit harder to track though.
next prev parent reply other threads:[~2011-12-01 18:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 19:37 [PATCH 0/4] nfc: Logging updates Joe Perches
2011-11-29 19:37 ` [PATCH 1/4] nfc: Use standard logging styles Joe Perches
2011-12-01 15:59 ` Samuel Ortiz
2011-12-01 18:48 ` Joe Perches [this message]
2011-12-01 19:09 ` Samuel Ortiz
2011-11-29 19:37 ` [PATCH 2/4] nfc: Convert nfc_dbg to pr_debug Joe Perches
2011-11-29 19:37 ` [PATCH 3/4] nfc: Remove unused nfc_printk and nfc_<level> macros Joe Perches
2011-11-29 19:37 ` [PATCH 4/4] nfc: Remove function tracer like entry messages Joe Perches
2011-12-01 16:01 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322765318.30801.9.camel@joe2Laptop \
--to=joe@perches.com \
--cc=aloisio.almeida@openbossa.org \
--cc=davem@davemloft.net \
--cc=lauro.venancio@openbossa.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).