From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: nuclear neigh patch
Date: Thu, 01 Dec 2011 22:17:20 +0100 [thread overview]
Message-ID: <1322774240.2750.30.camel@edumazet-laptop> (raw)
In-Reply-To: <20111201.152057.981138658170403943.davem@davemloft.net>
Le jeudi 01 décembre 2011 à 15:20 -0500, David Miller a écrit :
> Eric, how lucky are you feeling today? :-)
>
> Here is a patch that gets rid of the neighbour reference for ipv4 routes.
> Neigh entries are computed at packet send time in ip_output.c
>
> Some minor work is needed before we can flat out use something like this,
> the main issue being that there are places that assume that if we have
> a 'dst' entry then there is a non-NULL neighbour unconditionally available.
> Mainly this happens in the infiniband layer.
>
> So we can't create a situation where dst_get_neighbour() might return NULL
> just yet.
>
> This is worth sorting out, because then we can get rid of the neigh
> pointer entirely from dst entries.
>
> But anyways, if this patch works it would be interesting to see what
> it does to the UDP tests on your test machine(s).
Sure, this looks great.
I'll try this tomorrow on my test machines, its 10:15pm here ;)
prev parent reply other threads:[~2011-12-01 21:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 20:20 nuclear neigh patch David Miller
2011-12-01 21:17 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322774240.2750.30.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox