From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Michael Wang <wangyun@linux.vnet.ibm.com>,
Flavio Leitner <fbl@redhat.com>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>
Subject: Re: [net-next 1/6] e1000e: Avoid wrong check on TX hang
Date: Sat, 03 Dec 2011 23:28:36 -0800 [thread overview]
Message-ID: <1322983717.24828.8.camel@jtkirshe-mobl> (raw)
In-Reply-To: <20111203.222659.277419094309941060.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Sat, 2011-12-03 at 19:26 -0800, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Sat, 3 Dec 2011 03:44:26 -0800
>
> > + if ((!adapter->tx_hang_recheck) &&
>
> Excessive parenthesis, please remove.
>
> > + adapter->tx_hang_recheck = 1;
>
> This variable is a bool, set it to true or false.
>
> > + adapter->tx_hang_recheck = 0;
>
> Likewise.
>
> > + adapter->tx_hang_recheck = 0;
>
> Likewise.
Michael/Flavio -
To expedite this patch, I can make the changes that Dave is requesting
and re-submit v2 of the patch, if that is ok with you.
-Jeff
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-12-04 7:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-03 11:44 [net-next 0/6][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2011-12-03 11:44 ` [net-next 1/6] e1000e: Avoid wrong check on TX hang Jeff Kirsher
2011-12-04 3:26 ` David Miller
2011-12-04 7:28 ` Jeff Kirsher [this message]
2011-12-05 1:05 ` Michael Wang
2011-12-05 6:25 ` Jeff Kirsher
2011-12-05 7:15 ` Michael Wang
2011-12-05 8:02 ` Jeff Kirsher
2011-12-05 8:18 ` Michael Wang
2011-12-05 8:24 ` Jeff Kirsher
2011-12-03 11:44 ` [net-next 2/6] e1000e: hitting BUG_ON() from napi_enable Jeff Kirsher
2011-12-03 11:44 ` [net-next 3/6] igb: Update DMA Coalescing threshold calculation Jeff Kirsher
2011-12-03 11:44 ` [net-next 4/6] ixgbe: DCBnl set_all, order of operations fix Jeff Kirsher
2011-12-03 11:44 ` [net-next 5/6] ixgbe: DCB: IEEE transitions may fail to reprogram hardware Jeff Kirsher
2011-12-03 11:44 ` [net-next 6/6] ixgbe: Remove function prototype for non-existent function Jeff Kirsher
-- strict thread matches above, loose matches on Subject: below --
2011-12-05 8:20 [net-next 0/6 v2][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2011-12-05 8:20 ` [net-next 1/6] e1000e: Avoid wrong check on TX hang Jeff Kirsher
2011-12-05 8:37 ` Michael Wang
2011-12-05 13:49 ` Flavio Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322983717.24828.8.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=fbl@redhat.com \
--cc=gospo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=wangyun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).