Re: [PATCH] drivers/net/usb/asix: resync from vendor's copy

[Ben Hutchings <bhutchings@solarflare.com>]

On Mon, 2011-12-05 at 09:41 -0500, Mark Lord wrote:
[...]
> static int ax88772b_bind(struct usbnet *dev, struct usb_interface *intf)
> {
> ...
>         /* register support for hardware checksums */
>         dev->net->hw_features |= NETIF_F_HW_CSUM | NETIF_F_RXCSUM;
> 
>         /* enable hardware checksums */
>         dev->net->features |= NETIF_F_HW_CSUM | NETIF_F_RXCSUM;
>         ax88772b_set_features(dev->net, dev->net->features);
> ...
> }
> -------------------------------snip-----------------------------------
> 
> Does this look correct -- any improvements/fixes to suggest?
[...]

NETIF_F_HW_CSUM means the hardware implements generic IP-style
checksumming: the stack specifies the offset at which to start
checksumming and the offset at which to store the checksum, and the
hardware does not attempt to parse the headers.

If this hardware recognises specific protocols and works out the offsets
itself, then you must claim NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM instead.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.