netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: mchan@broadcom.com, netdev@vger.kernel.org, barak@broadcom.com,
	eilong@broadcom.com
Subject: Re: [PATCH net-next 3/4] bnx2x: support classification config query
Date: Mon, 05 Dec 2011 21:59:19 -0800	[thread overview]
Message-ID: <1323151159.19483.14.camel@joe2Laptop> (raw)
In-Reply-To: <20111206.004629.1477080329086805790.davem@davemloft.net>

On Tue, 2011-12-06 at 00:46 -0500, David Miller wrote:
> > +			DP(BNX2X_MSG_SP, "copied element number "
> > +				   "%d to address %p element was "
> > +				   "%pM\n", counter, next, pos->u.mac.mac);
> 
> Likewise.

Ideally, the format should be coalesced as well.

			DP(BNX2X_MSG_SP, "copied element number %d to address %p - element was %pM\n",
			   counter, next, pos->u.mac.mac);

      parent reply	other threads:[~2011-12-06  5:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-06  5:44 [PATCH net-next 1/4] bnx2x: add PFC statistics Michael Chan
2011-12-06  5:44 ` [PATCH net-next 2/4] bnx2x: add fcoe statistics Michael Chan
2011-12-06  5:44   ` [PATCH net-next 3/4] bnx2x: support classification config query Michael Chan
2011-12-06  5:44     ` [PATCH net-next 4/4] bnx2x, cnic: support DRV_INFO upon FW request Michael Chan
2011-12-06  5:56       ` Joe Perches
2011-12-06  5:46     ` [PATCH net-next 3/4] bnx2x: support classification config query David Miller
2011-12-06  5:57       ` Michael Chan
2011-12-06  5:59       ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323151159.19483.14.camel@joe2Laptop \
    --to=joe@perches.com \
    --cc=barak@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=eilong@broadcom.com \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).