From: Joe Perches <joe@perches.com>
To: Michael Chan <mchan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, barak@broadcom.com,
eilong@broadcom.com
Subject: Re: [PATCH net-next 4/4 v2] bnx2x, cnic: support DRV_INFO upon FW request
Date: Mon, 05 Dec 2011 23:58:14 -0800 [thread overview]
Message-ID: <1323158294.1762.4.camel@joe2Laptop> (raw)
In-Reply-To: <1323157945-28333-4-git-send-email-mchan@broadcom.com>
On Mon, 2011-12-05 at 23:52 -0800, Michael Chan wrote:
> From: Barak Witkowski <barak@broadcom.com>
> Add support to send driver capabilities, settings and statistics to
> management firmware.
[]
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h
[]
> @@ -1965,9 +1970,38 @@ struct shmem2_region {
[]
> + u32 drv_capabilities_flag[E2_FUNC_MAX];
> + #define DRV_FLAGS_CAPABALITIES_LOADED_SUPPORTED 0x00000001
capabilities.
> + #define DRV_FLAGS_CAPABILITIES_LOADED_L2 0x00000002
> + #define DRV_FLAGS_CAPABILITIES_LOADED_FCOE 0x00000004
> + #define DRV_FLAGS_CAPABILITIES_LOADED_ISCSI 0x00000008
I think the #defines should be left aligned.
> +/* Per PCI Function FCOE Statistics required from the driver */
> +struct fcoe_stats_info {
> + u8 version[12]; /* Function's Driver Version. */
> + u8 mac_local[8]; /* Locally Admin Addr. */
> + u8 mac_add1[8]; /* Additional Programmed MAC Addr 1. */
> + u8 mac_add2[8]; /* Additional Programmed MAC Addr 2. */
Should these addresses be u8 name[6]?
next prev parent reply other threads:[~2011-12-06 7:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 7:52 [PATCH net-next 1/4 v2] bnx2x: add PFC statistics Michael Chan
2011-12-06 7:52 ` [PATCH net-next 2/4 v2] bnx2x: add fcoe statistics Michael Chan
2011-12-06 7:52 ` [PATCH net-next 3/4 v2] bnx2x: support classification config query Michael Chan
2011-12-06 7:52 ` [PATCH net-next 4/4 v2] bnx2x, cnic: support DRV_INFO upon FW request Michael Chan
2011-12-06 7:58 ` Joe Perches [this message]
2011-12-06 8:12 ` Michael Chan
2011-12-06 8:24 ` Michael Chan
2011-12-11 13:47 ` Barak Witkowski
2011-12-06 18:06 ` [PATCH net-next 3/4 v2] bnx2x: support classification config query David Miller
2011-12-06 18:06 ` [PATCH net-next 2/4 v2] bnx2x: add fcoe statistics David Miller
2011-12-06 18:06 ` [PATCH net-next 1/4 v2] bnx2x: add PFC statistics David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323158294.1762.4.camel@joe2Laptop \
--to=joe@perches.com \
--cc=barak@broadcom.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).