Re: [PATCH net-next 4/6] tg3: Track LP advertising

[Ben Hutchings <bhutchings@solarflare.com>]

On Thu, 2011-12-08 at 13:50 -0800, Matt Carlson wrote:
> This patch adds code to track the autonegotiation advertisements of the
> link partner and report them through ethtool.
> 
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Reviewed-by: Michael Chan <mchan@broadcom.com>
> ---
>  drivers/net/ethernet/broadcom/tg3.c |   41 ++++++++++++++++++++++++++++++++--
>  drivers/net/ethernet/broadcom/tg3.h |    1 +
>  2 files changed, 39 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index d1681db..ae1e838 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -3803,6 +3803,29 @@ static bool tg3_phy_copper_an_config_ok(struct tg3 *tp, u32 *lcladv)
>  	return true;
>  }
>  
> +static bool tg3_phy_copper_fetch_rmtadv(struct tg3 *tp, u32 *rmtadv)
> +{
> +	u32 val, lpeth = 0;
> +
> +	if (!(tp->phy_flags & TG3_PHYFLG_10_100_ONLY)) {
> +		if (tg3_readphy(tp, MII_STAT1000, &val))
> +			return false;
> +
> +		lpeth = mii_stat1000_to_ethtool_lpa_t(val);
> +	}
> +
> +	if (tg3_readphy(tp, MII_LPA, &val))
> +		return false;
> +
> +	lpeth |= mii_lpa_to_ethtool_lpa_t(val);
> +	tp->link_config.rmt_adv = lpeth;
> +
> +	if (tg3_flag(tp, PAUSE_AUTONEG))
> +		*rmtadv = val;

I assume that the caller only needs this information if pause autoneg is
enabled, but it's still very strange to put the condition here.

Ben.

> +	return true;
> +}
[...]

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.