netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Daniel Baluta <dbaluta@ixiacom.com>
Cc: Greg KH <greg@kroah.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	adobriyan@gmail.com
Subject: Re: [PATCH] kref: add function for reading kref value
Date: Mon, 12 Dec 2011 18:42:34 +0100	[thread overview]
Message-ID: <1323711754.2583.14.camel@edumazet-laptop> (raw)
In-Reply-To: <CAEnQRZAt0X6cxGLgLUVTB9rzLKVYLEnh=azS9WOyKAkUZEpj4g@mail.gmail.com>

Le lundi 12 décembre 2011 à 18:42 +0200, Daniel Baluta a écrit :

> Yes, but you have to do this each time you start debugging, for a
> particular referenced counted object.
> 

What a big deal.

> We must find a clever solution to avoid the noise. (e.g use
> /proc, /sysfs, /debugfs options to trigger dumping info for
> some/all objects with a certain state).
> 
> Usecase:
> 
> At some point we need to know all objects with refcount X,
> and their history of get/put operations.
> 
> For us it would have been very useful when debugging dev
> refcnts problems. With the current implementation kernel
> only dumped info at dev.c:5429:
> 

current on your git repo maybe, not on ours :(

> printk(KERN_EMERG "unregister_netdevice: "
>        waiting for %s to become free. Usage "
>        count = %d\n",
>        dev->name, atomic_read(&dev->refcnt));
> 

This is a very good example where you _cannot_ use kref, since we now
use a percpu refcnt fot netdevice.

      parent reply	other threads:[~2011-12-12 17:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1323693892-11570-1-git-send-email-dbaluta@ixiacom.com>
     [not found] ` <20111212150255.GA7506@kroah.com>
2011-12-12 15:21   ` [PATCH] kref: add function for reading kref value Daniel Baluta
2011-12-12 15:32     ` Eric Dumazet
2011-12-12 15:39       ` Daniel Baluta
2011-12-12 15:41         ` Eric Dumazet
2011-12-12 16:42           ` Daniel Baluta
2011-12-12 17:33             ` Greg KH
2011-12-12 17:46               ` Daniel Baluta
2011-12-12 17:57                 ` Eric Dumazet
2011-12-12 18:33                 ` Greg KH
2011-12-12 17:42             ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323711754.2583.14.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=adobriyan@gmail.com \
    --cc=dbaluta@ixiacom.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).