From: Vasu Dev <vasu.dev@linux.intel.com>
To: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>
Cc: Jiri Pirko <jpirko@redhat.com>, Vasu Dev <vasu.dev@intel.com>,
netdev@vger.kernel.org, devel@open-fcoe.org,
eric.dumazet@gmail.com
Subject: Re: [PATCH] net: do not pass vlan pkts to real dev pkt handler also
Date: Wed, 14 Dec 2011 15:55:23 -0800 [thread overview]
Message-ID: <1323906923.8333.64.camel@vi> (raw)
In-Reply-To: <4EE8FE86.90009@gmail.com>
On Wed, 2011-12-14 at 20:52 +0100, Nicolas de Pesloüan wrote:
> If a protocol handler is registered on a particular device (instead of
> NULL), then the handler will
> receive whatever is received on this device. This is true for bridge,
> for bonding and probably for
> all other "stackable" devices. I don't see any reason to handle it in
> a different way for vlan.
>
Yeah okay to have orig_dev pkt handler see its all vlan frames though we
didn't have that way until recent change but seems reasonable to have
this way now. So I'll fix fcoe by allowing frames matching to its own
device and that will exclude vlan frames on its orig_dev pkt handler.
However now each stacked vlan tag iteration would result in passing up
frame to its orig_dev pkt handler but don't know if that affects other
and anyway fcoe would be okay with that as well.
Thanks
Vasu
prev parent reply other threads:[~2011-12-15 0:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 22:19 [PATCH] net: do not pass vlan pkts to real dev pkt handler also Vasu Dev
2011-12-12 22:56 ` Jiri Pirko
2011-12-13 1:08 ` Vasu Dev
2011-12-13 14:21 ` Jiri Pirko
2011-12-13 17:11 ` Vasu Dev
2011-12-13 21:45 ` Jiri Pirko
2011-12-14 19:52 ` Nicolas de Pesloüan
2011-12-14 23:55 ` Vasu Dev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323906923.8333.64.camel@vi \
--to=vasu.dev@linux.intel.com \
--cc=devel@open-fcoe.org \
--cc=eric.dumazet@gmail.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@gmail.com \
--cc=vasu.dev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).