From: Joe Perches <joe@perches.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH 14/15] module_param: make bool parameters really bool (net & drivers/net)
Date: Wed, 14 Dec 2011 19:45:52 -0800 [thread overview]
Message-ID: <1323920752.29500.11.camel@joe2Laptop> (raw)
In-Reply-To: <877h1ysenl.fsf@rustcorp.com.au>
On Thu, 2011-12-15 at 13:51 +1030, Rusty Russell wrote:
> module_param(bool) used to counter-intuitively take an int. In
> fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
> trick.
[]
> diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c
[]
> @@ -38,15 +38,15 @@ MODULE_ALIAS_LDISC(N_CAIF);
[]
> -static int ser_use_stx = 1;
> +static bool ser_use_stx = 1;
Could you respin these please using bool foo = true/false instead?
next prev parent reply other threads:[~2011-12-15 3:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 3:21 [PATCH 14/15] module_param: make bool parameters really bool (net & drivers/net) Rusty Russell
2011-12-15 3:45 ` Joe Perches [this message]
2011-12-15 23:14 ` Rusty Russell
2011-12-16 0:33 ` Joe Perches
2011-12-19 5:38 ` Rusty Russell
2011-12-16 4:15 ` David Miller
2011-12-19 5:49 ` Rusty Russell
2011-12-19 6:42 ` Joe Perches
2011-12-19 21:22 ` David Miller
2011-12-19 23:54 ` Rusty Russell
2011-12-19 23:56 ` [PATCH 1/2] net: fix assignment of 0/1 to bool variables Rusty Russell
2011-12-20 6:56 ` David Miller
2011-12-20 0:08 ` [PATCH 2/2] module_param: make bool parameters really bool (net & drivers/net) Rusty Russell
2011-12-20 6:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323920752.29500.11.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).