From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH net-next 6/6] tg3: Make the RSS indir tbl admin configurable Date: Thu, 15 Dec 2011 21:13:47 +0000 Message-ID: <1323983627.2773.18.camel@bwh-desktop> References: <1323897002-17295-7-git-send-email-mcarlson@broadcom.com> <1323899459.2753.19.camel@bwh-desktop> <20111215210308.GA7025@mcarlson.broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , Michael Chan To: Matt Carlson Return-path: Received: from exchange.solarflare.com ([216.237.3.220]:59169 "EHLO ocex02.SolarFlarecom.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751811Ab1LOVNw (ORCPT ); Thu, 15 Dec 2011 16:13:52 -0500 In-Reply-To: <20111215210308.GA7025@mcarlson.broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 2011-12-15 at 13:03 -0800, Matt Carlson wrote: > On Wed, Dec 14, 2011 at 01:50:59PM -0800, Ben Hutchings wrote: > > On Wed, 2011-12-14 at 13:10 -0800, Matt Carlson wrote: [...] > > > + if (!indir->size) { > > > + indir->size = TG3_RSS_INDIR_TBL_SIZE; > > > + return 0; > > > + } > > > + > > > + if (indir->size != TG3_RSS_INDIR_TBL_SIZE) > > > + return -EINVAL; > > > > This is enough to make the ethtool command work, but you're really > > supposed to copy min(indir->size, TG3_RSS_INDIR_TBL_SIZE) entries. > > Could you elaborate on this? I'm confused because I can't figure out > how returning half of an indirection table could be useful. It's a generalisation of the zero-length and full-length cases. But no, it isn't very useful, nor did I actually specify that anywhere! Maybe there should be a driver operation to get the table size, and then the core can make sure that drivers only ever deal with full-table buffers. Though that wouldn't cover your reset-to-default case. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.