From: Joe Perches <joe@perches.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, pawel.moll@arm.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 14/15] module_param: make bool parameters really bool (net & drivers/net)
Date: Sun, 18 Dec 2011 22:42:56 -0800 [thread overview]
Message-ID: <1324276976.23473.4.camel@joe2Laptop> (raw)
In-Reply-To: <87ehw1nm9r.fsf@rustcorp.com.au>
On Mon, 2011-12-19 at 16:19 +1030, Rusty Russell wrote:
> diff --git a/drivers/net/ethernet/amd/amd8111e.h b/drivers/net/ethernet/amd/amd8111e.h
[]
> @@ -808,8 +808,8 @@ typedef enum {
[]
> +static bool coalesce[MAX_UNITS] = {1,1,1,1,1,1,1,1};
> +static bool dynamic_ipg[MAX_UNITS] = {0,0,0,0,0,0,0,0};
Perhaps these array initializations could/should be:
static bool coalesce[MAX_UNITS] = { [0 ... MAX_UNITS - 1] = true };
static bool dynamic_irq[MAX_UNITS] = { [0 ... MAX_UNITS - 1] = false };
in a separate patch maybe.
next prev parent reply other threads:[~2011-12-19 6:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 3:21 [PATCH 14/15] module_param: make bool parameters really bool (net & drivers/net) Rusty Russell
2011-12-15 3:45 ` Joe Perches
2011-12-15 23:14 ` Rusty Russell
2011-12-16 0:33 ` Joe Perches
2011-12-19 5:38 ` Rusty Russell
2011-12-16 4:15 ` David Miller
2011-12-19 5:49 ` Rusty Russell
2011-12-19 6:42 ` Joe Perches [this message]
2011-12-19 21:22 ` David Miller
2011-12-19 23:54 ` Rusty Russell
2011-12-19 23:56 ` [PATCH 1/2] net: fix assignment of 0/1 to bool variables Rusty Russell
2011-12-20 6:56 ` David Miller
2011-12-20 0:08 ` [PATCH 2/2] module_param: make bool parameters really bool (net & drivers/net) Rusty Russell
2011-12-20 6:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324276976.23473.4.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).