Re: [PATCH net-next] r8169: Support for byte queue limits

[Eric Dumazet <eric.dumazet@gmail.com>]

Le lundi 19 décembre 2011 à 10:27 +0100, igorm@etf.rs a écrit :
> From: Igor Maravic <igorm@etf.rs>
> 
> Changes to r8169 to use byte queue limits.
> 
> Signed-off-by: Igor Maravic <igorm@etf.rs>
> ---
>  drivers/net/ethernet/realtek/r8169.c |   13 +++++++++++--
>  1 files changed, 11 insertions(+), 2 deletions(-)
> 

What are the changes in this version, versus prior submissions ?

>  
>  static void rtl8169_schedule_work(struct net_device *dev, work_func_t task)
> @@ -5460,6 +5461,8 @@ static int rtl8169_xmit_frags(struct rtl8169_private *tp, struct sk_buff *skb,
>  		txd->opts1 |= cpu_to_le32(LastFrag);
>  	}
>  
> +	netdev_sent_queue(tp->dev, skb->len);
> +
>  	return cur_frag;
>  

Ignoring a review/comment/suggestion is not very wise, since I wont Ack
this patch as is, and I'll remember for your next patches that you dont
care of me taking the time to review your work.

Your choice.

Please call this from rtl8169_start_xmit() instead.
 
	netdev_sent_queue(dev, skb->len);