netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: netdev@vger.kernel.org
Subject: Allocation of small packets on Rx
Date: Tue, 20 Dec 2011 10:30:26 +1100	[thread overview]
Message-ID: <1324337426.30454.23.camel@pasglop> (raw)

Hi folks !

For a driver that gets small packets "inline" in the rx descriptors, I
allocate the skb in the rx poll and copy the data to it.

Should I allocate an skb of the just the right size for the packet (+
eventual alignment) or is there any benefit to allocating all skb's the
same size ?

The max size of those "inline" packets is 256 bytes and the driver today
always allocate that. Does that "help" the allocator some way or should
I just allocate what is needed for each packet ?

Cheers,
Ben.

                 reply	other threads:[~2011-12-19 23:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324337426.30454.23.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).