From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: alex.bluesman.smirnov@gmail.com, dbaryshkov@gmail.com,
linux-zigbee-devel@lists.sourceforge.net, netdev@vger.kernel.org,
alexander@Lenovo.com
Subject: Re: [PATCH 11/14] mac802154: slaves manipulation routine
Date: Mon, 19 Dec 2011 17:08:39 -0800 [thread overview]
Message-ID: <1324343319.1742.5.camel@joe2Laptop> (raw)
In-Reply-To: <20111219.144353.627184888133427434.davem@davemloft.net>
On Mon, 2011-12-19 at 14:43 -0500, David Miller wrote:
> From: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
> > + if ((--priv->hw->open_count) == 0)
> This is more canonical as "if (!--priv->hw->open_count)".
Shrug. I think this is more readable and
intelligible with the == 0.
A test of a non-bool or non-ptr to a specific value
seems reasonable to me.
next prev parent reply other threads:[~2011-12-20 1:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 16:31 [PATCH series v1] IEEE 802.15.4 MAC layer basic implementation Alexander Smirnov
2011-12-19 16:33 ` [PATCH 01/14] mac802154: basic ieee802.15.4 device structures Alexander Smirnov
2011-12-19 19:32 ` David Miller
2011-12-19 16:33 ` [PATCH 02/14] mac802154: allocation of ieee802154 device Alexander Smirnov
[not found] ` <1324312434-13151-2-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:34 ` David Miller
2011-12-19 16:33 ` [PATCH 03/14] mac802154: RX data path Alexander Smirnov
[not found] ` <1324312434-13151-3-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:36 ` David Miller
2011-12-19 16:33 ` [PATCH 04/14] mac802154: TX " Alexander Smirnov
[not found] ` <1324312434-13151-4-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:38 ` David Miller
[not found] ` <20111219163117.GA13123-AUGNqIMGY+bGcXpsla5Oef8+0UxHXcjY@public.gmane.org>
2011-12-19 16:33 ` [PATCH 05/14] mac802154: define reduced mlme operations Alexander Smirnov
2011-12-19 16:33 ` [PATCH 06/14] mac802154: slave interfaces definition Alexander Smirnov
[not found] ` <1324312434-13151-6-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:38 ` David Miller
2011-12-19 16:33 ` [PATCH 07/14] mac802154: reduced mlme operations Alexander Smirnov
2011-12-19 16:33 ` [PATCH 08/14] mac802154: basic mib support Alexander Smirnov
[not found] ` <1324312434-13151-8-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:39 ` David Miller
2011-12-19 16:33 ` [PATCH 09/14] ieee802154: remove ieee802154 policy from globals Alexander Smirnov
[not found] ` <1324312434-13151-9-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:40 ` David Miller
2011-12-19 16:33 ` [PATCH 10/14] ieee802154: interface type to be added Alexander Smirnov
[not found] ` <1324312434-13151-10-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:42 ` David Miller
2011-12-19 16:33 ` [PATCH 11/14] mac802154: slaves manipulation routine Alexander Smirnov
[not found] ` <1324312434-13151-11-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:43 ` David Miller
2011-12-20 1:08 ` Joe Perches [this message]
2011-12-19 16:33 ` [PATCH 12/14] mac802154: monitor device support Alexander Smirnov
2011-12-19 19:47 ` David Miller
2011-12-19 16:33 ` [PATCH 13/14] drivers/ieee802154: IEEE 802.15.4 loopback driver Alexander Smirnov
[not found] ` <1324312434-13151-13-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-19 19:49 ` David Miller
2011-12-19 16:33 ` [PATCH 14/14] Documentation/networking/ieee802154: update MAC chapter Alexander Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324343319.1742.5.camel@joe2Laptop \
--to=joe@perches.com \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=alexander@Lenovo.com \
--cc=davem@davemloft.net \
--cc=dbaryshkov@gmail.com \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).