From: Eric Dumazet <eric.dumazet@gmail.com>
To: Satoru Moriya <satoru.moriya@hds.com>
Cc: Hagen Paul Pfeifer <hagen@jauu.net>,
Stephen Hemminger <stephen.hemminger@vyatta.com>,
"nhorman@tuxdriver.com" <nhorman@tuxdriver.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"tgraf@infradead.org" <tgraf@infradead.org>,
Seiji Aguchi <seiji.aguchi@hds.com>,
"dle-develop@lists.sourceforge.net"
<dle-develop@lists.sourceforge.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH 0/2] Tracepoint for tcp retransmission
Date: Wed, 21 Dec 2011 08:05:11 +0100 [thread overview]
Message-ID: <1324451111.2610.13.camel@edumazet-laptop> (raw)
In-Reply-To: <65795E11DBF1E645A09CEC7EAEE94B9CB5AFB01E@USINDEVS02.corp.hds.com>
Le mardi 20 décembre 2011 à 18:40 -0500, Satoru Moriya a écrit :
> We use trace_kfree_skb() which 63e03724b51 uses to detect packet
> drop event. In addition to that, we would like to detect errors
> in TCP layer for better trouble shooting.
>
If you feel we miss a counter in a particular spot, just add it, so that
even a newbie can report "netstat -s" values in a message for analysis.
Not re-sending a frame because of a temporary shortage of memory is not
an error per se, TCP will recover eventually, but keeping track of these
events might be useful (once we have not percpu counters for this, but
regular atomic counters)
next prev parent reply other threads:[~2011-12-21 7:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 22:14 [PATCH 0/2] Tracepoint for tcp retransmission Satoru Moriya
2011-12-16 22:16 ` [PATCH 1/2] tcp: refactor tcp_retransmit_skb() for a single return point Satoru Moriya
2011-12-19 12:10 ` David Laight
2011-12-20 16:55 ` Satoru Moriya
2011-12-16 22:17 ` [PATCH 2/2] tcp: add tracepoint for tcp retransmission Satoru Moriya
2011-12-17 0:17 ` [PATCH 0/2] Tracepoint " Stephen Hemminger
2011-12-18 0:49 ` Hagen Paul Pfeifer
2011-12-20 23:40 ` Satoru Moriya
2011-12-21 7:05 ` Eric Dumazet [this message]
2011-12-20 18:13 ` Satoru Moriya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324451111.2610.13.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dle-develop@lists.sourceforge.net \
--cc=hagen@jauu.net \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=satoru.moriya@hds.com \
--cc=seiji.aguchi@hds.com \
--cc=stephen.hemminger@vyatta.com \
--cc=tgraf@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox