From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH, v2] Xen: consolidate and simplify struct xenbus_driver instantiation Date: Thu, 22 Dec 2011 11:57:40 +0000 Message-ID: <1324555060.7877.84.camel@zakaz.uk.xensource.com> References: <4EF3018D020000780006986E@nat28.tlf.novell.com> <1324547820.7877.71.camel@zakaz.uk.xensource.com> <4EF327E2020000780006993E@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Konrad Rzeszutek Wilk , "davem@davemloft.net" , "dmitry.torokhov@gmail.com" , "FlorianSchandinat@gmx.de" , Jeremy Fitzhardinge , "Jens Axboe" , "xen-devel@lists.xensource.com" , Konrad Rzeszutek Wilk , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" To: Jan Beulich Return-path: In-Reply-To: <4EF327E2020000780006993E@nat28.tlf.novell.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 2011-12-22 at 11:51 +0000, Jan Beulich wrote: > >>> On 22.12.11 at 10:57, Ian Campbell wrote: > > On Thu, 2011-12-22 at 09:08 +0000, Jan Beulich wrote: > >> The 'name', 'owner', and 'mod_name' members are redundant with the > >> identically named fields in the 'driver' sub-structure. Rather than > >> switching each instance to specify these fields explicitly, introduce > >> a macro to simplify this. > >> > >> Eliminate further redundancy by allowing the drvname argument to > >> DEFINE_XENBUS_DRIVER() to be blank (in which case the first entry from > >> the ID table will be used for .driver.name). > > > > Any reason not to always use DRV_NAME here (which is generally a bit > > more specific e.g. "xen-foofront" rather than "foo") and rely on the id > > table for the shorter names used in xenstore? > > That would imply that DRV_NAME is always defined, but I don't > see this being the case. My mistake, I thought it was a Kbuild thing. Ian.