From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, dave.taht@gmail.com
Subject: Re: [PATCH net-next v2] net_sched: qdisc_alloc_handle() can be too slow
Date: Tue, 03 Jan 2012 21:34:52 +0100 [thread overview]
Message-ID: <1325622892.2611.11.camel@edumazet-laptop> (raw)
In-Reply-To: <20120103.130353.716810185692904362.davem@davemloft.net>
Le mardi 03 janvier 2012 à 13:03 -0500, David Miller a écrit :
> Applied, thanks Eric. I always cringed when I looked at this function :)
>
Yep :(
I'll add an IDR (and not a btree as I stated earlier) to get O(1)
allocations and qdisc_lookup(), it should help to optimize
qdisc_tree_decrease_qlen() [ Slow as hell for complex qdisc setups ]
prev parent reply other threads:[~2012-01-03 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 9:58 [PATCH net-next] net_sched: qdisc_alloc_handle() can be too slow Eric Dumazet
2012-01-03 10:00 ` [PATCH net-next v2] " Eric Dumazet
2012-01-03 10:23 ` Dave Taht
2012-01-03 18:03 ` David Miller
2012-01-03 20:34 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325622892.2611.11.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox