From: Joe Perches <joe@perches.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linville@tuxdriver.com, sfr@canb.auug.org.au,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
ath6kl-devel@qualcomm.com, davem@davemloft.net
Subject: Re: [PATCH 4/6] ath6kl: get rid of AR_DBG_LVL_CHECK()
Date: Wed, 04 Jan 2012 15:58:35 -0800 [thread overview]
Message-ID: <1325721515.4116.11.camel@joe2Laptop> (raw)
In-Reply-To: <20120104230921.32306.63985.stgit@x201>
On Thu, 2012-01-05 at 01:09 +0200, Kalle Valo wrote:
> We don't need it as debug calls already have a log level and compiler
> should be smart enough to optimise away the code when ath6kl debug code
> is not enabled. Also it makes it easier to abstract core code to
> ath6kl_core.ko.
Changelog isn't representative of code changes.
ATH6KL_DBG_ANY -> ATH6KL_DBG_IRQ.
> diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c
[]
> @@ -82,31 +82,31 @@ void ath6kl_dump_registers(struct ath6kl_device *dev,
> struct ath6kl_irq_enable_reg *irq_enable_reg)
> {
>
> - ath6kl_dbg(ATH6KL_DBG_ANY, ("<------- Register Table -------->\n"));
> + ath6kl_dbg(ATH6KL_DBG_IRQ, ("<------- Register Table -------->\n"));
etc...
next prev parent reply other threads:[~2012-01-04 23:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 23:07 [PATCH 0/6] ath6kl: create ath6kl_core.ko Kalle Valo
2012-01-04 23:07 ` [PATCH 1/6] ath6kl: rename vif init and cleanup functions Kalle Valo
2012-01-04 23:08 ` [PATCH 2/6] ath6kl: unify cfg80211 init/cleanup functions Kalle Valo
2012-01-04 23:08 ` [PATCH 3/6] ath6kl: create core.c Kalle Valo
2012-01-04 23:09 ` [PATCH 4/6] ath6kl: get rid of AR_DBG_LVL_CHECK() Kalle Valo
2012-01-04 23:58 ` Joe Perches [this message]
2012-01-05 8:57 ` Kalle Valo
2012-01-04 23:09 ` [PATCH 5/6] ath6kl: convert ath6kl_dbg() and ath6kl_dbg_dump() into functions Kalle Valo
2012-01-04 23:41 ` Joe Perches
2012-01-05 8:22 ` Kalle Valo
2012-01-05 10:41 ` David Laight
2012-01-05 16:30 ` Joe Perches
2012-01-04 23:10 ` [PATCH 6/6] ath6kl: create ath6kl_core.ko Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325721515.4116.11.camel@joe2Laptop \
--to=joe@perches.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=davem@davemloft.net \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).