netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: netdev@vger.kernel.org
Cc: David Miller <davem@davemloft.net>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH 1/6] net: pack skb_shared_info more efficiently
Date: Thu, 5 Jan 2012 17:13:39 +0000	[thread overview]
Message-ID: <1325783624-14601-1-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1325783399.25206.413.camel@zakaz.uk.xensource.com>

nr_frags can be 8 bits since 256 is plenty of fragments. This allows it to be
packed with tx_flags.

Also by moving ip6_frag_id and dataref (both 4 bytes) next to each other we can
avoid a hole between ip6_frag_id and frag_list on 64 bit systems.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 include/linux/skbuff.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index f47f0c3..50db9b0 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -242,15 +242,15 @@ struct ubuf_info {
  * the end of the header data, ie. at skb->end.
  */
 struct skb_shared_info {
-	unsigned short	nr_frags;
+	unsigned char	nr_frags;
+	__u8		tx_flags;
 	unsigned short	gso_size;
 	/* Warning: this field is not always filled in (UFO)! */
 	unsigned short	gso_segs;
 	unsigned short  gso_type;
-	__be32          ip6_frag_id;
-	__u8		tx_flags;
 	struct sk_buff	*frag_list;
 	struct skb_shared_hwtstamps hwtstamps;
+	__be32          ip6_frag_id;
 
 	/*
 	 * Warning : all fields before dataref are cleared in __alloc_skb()
-- 
1.7.2.5

  reply	other threads:[~2012-01-05 17:13 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-05 17:09 [PATCH 0/6 v2] skb paged fragment destructors Ian Campbell
2012-01-05 17:13 ` Ian Campbell [this message]
2012-01-05 18:30   ` [PATCH 1/6] net: pack skb_shared_info more efficiently Eric Dumazet
2012-01-05 19:09     ` David Miller
2012-01-05 17:13 ` [PATCH 2/6] net: pad skb data and shinfo as a whole rather than individually Ian Campbell
2012-01-05 17:46   ` Eric Dumazet
2012-01-05 19:13     ` David Miller
2012-01-05 20:00       ` Ian Campbell
2012-01-07 18:18         ` David Miller
2012-01-05 19:19     ` Ian Campbell
2012-01-05 20:22       ` Eric Dumazet
2012-01-06 11:20         ` Ian Campbell
2012-01-06 12:33           ` Eric Dumazet
2012-01-06 13:20             ` Ian Campbell
2012-01-06 13:37               ` Eric Dumazet
2012-01-06 13:49                 ` Ian Campbell
2012-01-06 13:29             ` Ian Campbell
2012-01-05 17:13 ` [PATCH 3/6] net: add support for per-paged-fragment destructors Ian Campbell
2012-01-06  1:15   ` Michał Mirosław
2012-01-06  8:50     ` Ian Campbell
2012-01-05 17:13 ` [PATCH 4/6] net: only allow paged fragments with the same destructor to be coalesced Ian Campbell
2012-01-05 17:13 ` [PATCH 5/6] net: add paged frag destructor support to kernel_sendpage Ian Campbell
2012-01-05 19:15   ` David Miller
2012-01-05 20:04     ` Ian Campbell
     [not found] ` <1325783399.25206.413.camel-o4Be2W7LfRlXesXXhkcM7miJhflN2719@public.gmane.org>
2012-01-05 17:13   ` [PATCH 6/6] sunrpc: use SKB fragment destructors to delay completion until page is released by network stack Ian Campbell
2012-01-05 17:27 ` [PATCH 0/6 v2] skb paged fragment destructors David Laight
2012-01-05 17:34   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1325783624-14601-1-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).