netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: bridge: netfilter: Fix dependency for BRIDGE_NF_EBTABLES
@ 2012-01-11  1:48 Fabio Estevam
  2012-01-11  1:52 ` Stephen Hemminger
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2012-01-11  1:48 UTC (permalink / raw)
  To: netdev; +Cc: bridge, davem, shemminger, Fabio Estevam, Fabio Estevam

Fix the following build warning:

warning: (BRIDGE_NF_EBTABLES) selects NETFILTER_XTABLES which has unmet direct dependencies (NET && INET && NETFILTER)

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 net/bridge/netfilter/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/bridge/netfilter/Kconfig b/net/bridge/netfilter/Kconfig
index a9aff9c..9ca621a 100644
--- a/net/bridge/netfilter/Kconfig
+++ b/net/bridge/netfilter/Kconfig
@@ -4,7 +4,7 @@
 
 menuconfig BRIDGE_NF_EBTABLES
 	tristate "Ethernet Bridge tables (ebtables) support"
-	depends on BRIDGE && NETFILTER
+	depends on BRIDGE && NETFILTER && INET
 	select NETFILTER_XTABLES
 	help
 	  ebtables is a general, extensible frame/packet identification
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: bridge: netfilter: Fix dependency for BRIDGE_NF_EBTABLES
  2012-01-11  1:48 [PATCH] net: bridge: netfilter: Fix dependency for BRIDGE_NF_EBTABLES Fabio Estevam
@ 2012-01-11  1:52 ` Stephen Hemminger
  2012-01-11  6:32   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2012-01-11  1:52 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: Fabio Estevam, netdev, bridge, davem

On Tue, 10 Jan 2012 23:48:25 -0200
Fabio Estevam <festevam@gmail.com> wrote:

> Fix the following build warning:
> 
> warning: (BRIDGE_NF_EBTABLES) selects NETFILTER_XTABLES which has unmet direct dependencies (NET && INET && NETFILTER)
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  net/bridge/netfilter/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/bridge/netfilter/Kconfig b/net/bridge/netfilter/Kconfig
> index a9aff9c..9ca621a 100644
> --- a/net/bridge/netfilter/Kconfig
> +++ b/net/bridge/netfilter/Kconfig
> @@ -4,7 +4,7 @@
>  
>  menuconfig BRIDGE_NF_EBTABLES
>  	tristate "Ethernet Bridge tables (ebtables) support"
> -	depends on BRIDGE && NETFILTER
> +	depends on BRIDGE && NETFILTER && INET
>  	select NETFILTER_XTABLES
>  	help
>  	  ebtables is a general, extensible frame/packet identification

Almost everybody has INET defined... but still it should be possible to run ebtables
without INET layer. Looks like a but in XTABLES to me.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: bridge: netfilter: Fix dependency for BRIDGE_NF_EBTABLES
  2012-01-11  1:52 ` Stephen Hemminger
@ 2012-01-11  6:32   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2012-01-11  6:32 UTC (permalink / raw)
  To: shemminger; +Cc: festevam, netdev, bridge, fabio.estevam, netfilter-devel

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 10 Jan 2012 17:52:51 -0800

> On Tue, 10 Jan 2012 23:48:25 -0200
> Fabio Estevam <festevam@gmail.com> wrote:
> 
>> Fix the following build warning:
>> 
>> warning: (BRIDGE_NF_EBTABLES) selects NETFILTER_XTABLES which has unmet direct dependencies (NET && INET && NETFILTER)
>> 
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>>  net/bridge/netfilter/Kconfig |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/net/bridge/netfilter/Kconfig b/net/bridge/netfilter/Kconfig
>> index a9aff9c..9ca621a 100644
>> --- a/net/bridge/netfilter/Kconfig
>> +++ b/net/bridge/netfilter/Kconfig
>> @@ -4,7 +4,7 @@
>>  
>>  menuconfig BRIDGE_NF_EBTABLES
>>  	tristate "Ethernet Bridge tables (ebtables) support"
>> -	depends on BRIDGE && NETFILTER
>> +	depends on BRIDGE && NETFILTER && INET
>>  	select NETFILTER_XTABLES
>>  	help
>>  	  ebtables is a general, extensible frame/packet identification
> 
> Almost everybody has INET defined... but still it should be possible to run ebtables
> without INET layer. Looks like a but in XTABLES to me.

And this needs to be CC:'d to the netfilter folks meanwhile, added...

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-01-11  6:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-11  1:48 [PATCH] net: bridge: netfilter: Fix dependency for BRIDGE_NF_EBTABLES Fabio Estevam
2012-01-11  1:52 ` Stephen Hemminger
2012-01-11  6:32   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).